Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UsersConnectionSearchColumnEnum values should be prefixed with user_ #3045

Merged

Conversation

justlevine
Copy link
Collaborator

What does this implement/fix? Explain your changes.

This PR fixes the Enum values used by UserConnectionSearchColumnEnum to use the prefixed user_* as expected by WP_User_Query

Does this close any currently open issues?

Fixes #2419

Any relevant logs, error output, GraphiQL screenshots, etc?

image

Any other comments?

Where has this been tested?

Operating System: Ubuntu 20.04 (wsl2 + devilbox + php8.1.14)

WordPress Version: 6.4.3

Copy link

codeclimate bot commented Feb 11, 2024

Code Climate has analyzed commit ada326e and detected 0 issues on this pull request.

View more on Code Climate.

@justlevine justlevine added Type: Bug Something isn't working Component: Connections Issues related to connections ObjectType: User Status: In Review Needs to be reviewed by a project maintainer before merge labels Feb 11, 2024
@coveralls
Copy link

Coverage Status

coverage: 84.275%. remained the same
when pulling ada326e on justlevine:fix/user-searchColumns-filter
into afe6a52 on wp-graphql:develop.

@jasonbahl jasonbahl merged commit 0fd7820 into wp-graphql:develop Feb 13, 2024
23 checks passed
@justlevine justlevine deleted the fix/user-searchColumns-filter branch February 14, 2024 00:02
@jasonbahl jasonbahl mentioned this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Connections Issues related to connections ObjectType: User Status: In Review Needs to be reviewed by a project maintainer before merge Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

searchColumns parameter in users Query doesn't work.
3 participants