fix: respect show avatar setting #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit a36e4f3 and detected 0 issues on this pull request. View more on Code Climate. |
josephfusco
approved these changes
Mar 6, 2024
3 tasks
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This fixes a bug where avatar information would be returned even if the "show_avatars" setting is turned "off" under Settings > Discussion.
Does this close any currently open issues?
closes #3064
Any other comments?
This doesn't change the schema, just the resolve logic.
Since the Avatar field is already nullable, responsible consumers should already be prepared to expect null values for avatars, so preventing avatars from being returned is not considered a breaking change.