New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Update actions in GitHub workflows and cleanup #3093
Conversation
f6cbc20
to
6e5de4b
Compare
4aa2d1f
to
6b56ecb
Compare
34368c2
to
33c6e97
Compare
WP 5.2 on PHP 7.3 is failing for @jasonbahl @josephfusco any ideas (branch edits open, so feel free to fix directly on this branch if you have a solve) |
@justlevine I'm not sure we need to prioritize testing 5.2. We haven't been testing against it before and according to the telemetry data we collect, we have 0 users on 5.2. We have:
|
It's less about 5.2 specifically, and more about testing our "minimum supported version" now and in the future. If it's not worth fixing the Codeception test, I can keep bumping until we find a minimum version that just works. |
@justlevine ya, I think the effort is better spent ensuring things work on more recent versions and coming up with a plan / policy for supported versions that we can put into place and follow over time. i.e. "we will officially support the latest xx versions of WordPress and the last xx versions of PHP" or something to that tune. Definitely needs more thought than that, but I think there's more value in encouraging folks to update vs putting effort into testing versions we wouldn't actively recommend be used in the first place 🤷🏻♂️ |
💯 The goal of the matrix changes in this PR is not philosophical, only a cleaner restructure of the matrix to make it easier to add/change versions without losing coverage. Will find a docker build that works as-is and ping you for re-review. |
ad405d6
to
51e31c4
Compare
51e31c4
to
f57709f
Compare
Code Climate has analyzed commit f57709f and detected 0 issues on this pull request. View more on Code Climate. |
@jasonbahl WP 5.5 is the magic number. |
What does this implement/fix? Explain your changes.
This PR:
matrix
testing from our workflows when only one value (e.g.php-version
,node-version
) used.styfle/cancel-workflow-action
with the built-inconcurrency
property.This PR does not
Does this close any currently open issues?
Any relevant logs, error output, GraphiQL screenshots, etc?
Any other comments?
Once this is merged, we'll need to update the repo settings for required actions.
Where has this been tested?
Operating System: n/a (See action history for this PR)
WordPress Version: 6.5.0