-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue#20 widget queries #485
Closed
kidunot89
wants to merge
21
commits into
wp-graphql:develop
from
kidunot89:issue#20-21-widget-queries-and-mutations
Closed
Issue#20 widget queries #485
kidunot89
wants to merge
21
commits into
wp-graphql:develop
from
kidunot89:issue#20-21-widget-queries-and-mutations
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kidunot89 this is rad. Thanks for working on this. I will give it a good run through and review this week. Thanks! |
jasonbahl
requested review from
jasonbahl,
CodeProKid,
hughdevore,
chriszarate and
0aveRyan
August 7, 2018 20:28
jasonbahl
added
Status: In Review
Needs to be reviewed by a project maintainer before merge
Status: In Progress
Type: Feature
labels
Aug 7, 2018
kidunot89
force-pushed
the
issue#20-21-widget-queries-and-mutations
branch
from
August 9, 2018 04:35
1a6916e
to
0a64b0a
Compare
…t_query_info and array_slice modified
…t_query_info and array_slice modified
…t_query_info and array_slice modified
…t_query_info and array_slice modified
…t_query_info and array_slice modified
…t_query_info and array_slice modified
kidunot89
force-pushed
the
issue#20-21-widget-queries-and-mutations
branch
from
August 9, 2018 23:18
8271735
to
34376ff
Compare
Is there documentation somewhere about building a Graph QL query to build a side bar widget? I didn't see it on the main site. Thanks |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: In Progress
Status: In Review
Needs to be reviewed by a project maintainer before merge
Type: Feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.
🚨Please review the guidelines for contributing to this repository.
What does this implement/fix? Explain your changes.
Adds Sidebar/Widget types and connections. As well as
InterfaceType
wrapperWPGraphQL\Type\WPInterfaceType
and abstract classWPGraphQL\TypeRegistry
for creating TypeRegistries.Example
TypeRegistry
TypeRegistry::$types
can also be extended by thegraphql_register_{$registry_name}::{$type_name}
The
$registry_name
is set in the constructor. The constructor is meant to be called at the end of constructor of whatevertype
the registry is meant to extend e.g.self::$registry = new TypeRegistry( $registry_name );
. I haven't to write test for it yet because it manifested itself as I was cleaning up theWidgetTypes
classDoes this close any currently open issues?
#20 #327
Any relevant logs, error output, GraphiQL screenshots, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Any other comments?
I'm holding off on mutations until the types and connections are reviewed and merged.
Where has this been tested?
Operating System: Ubuntu 18.04
WordPress Version: 4.9.6