Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clone field within a group field type returns null values #185

Merged
merged 5 commits into from Mar 6, 2024

Conversation

jasonbahl
Copy link
Contributor

@jasonbahl jasonbahl commented Mar 4, 2024

What does this implement/fix? Explain your changes.

checks if the value is being passed down with the' __key' or the 'key' to better compensate for clone fields, specifically when groups are cloned

Does this close any currently open issues?

fixes #184
fixes #151

Any other comments?

I believe this addresses the issues reported in #184 and #184

Below are some before/after examples:

Issue 184

Following the reported steps to reproduce (see #184):

Before

CleanShot 2024-03-04 at 16 04 35

After

CleanShot 2024-03-04 at 15 50 53

Issue 151

Following the reported steps to reproduce (see #151):

Before

CleanShot 2024-03-04 at 16 10 46

After

CleanShot 2024-03-04 at 16 09 59

…y' to better compensate for clone fields, specifically when groups are cloned
@coveralls
Copy link

coveralls commented Mar 4, 2024

Pull Request Test Coverage Report for Build 8a34ff48313691d4393305f21bf89808a50005f3-PR-185

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.9%) to 63.437%

Files with Coverage Reduction New Missed Lines %
src/FieldConfig.php 1 91.8%
Totals Coverage Status
Change from base Build b06cf287065c039152c7340ce8fd971acbb91391: 0.9%
Covered Lines: 2082
Relevant Lines: 3282

💛 - Coveralls

@jasonbahl jasonbahl merged commit ece620b into develop Mar 6, 2024
25 checks passed
@jasonbahl jasonbahl mentioned this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clone Field placed within a Group Field returns null values Clone Fields Do not work Properly
2 participants