Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v2.2.0 #190

Merged
merged 23 commits into from
Mar 15, 2024
Merged

release: v2.2.0 #190

merged 23 commits into from
Mar 15, 2024

Conversation

jasonbahl
Copy link
Contributor

2.2.0

New Features

  • #181: feat: update docs Date fields to link to the RFC3339 spec

Chores / Bugfixes

  • #182: fix: admin_enqueue_scripts callback should expect a possible null value passed to it
  • #185: fix: clone field within a group field type returns null values
  • #189: fix: image fields (and other connection fields) not properly resolving when queried asPreview

…ster_graphql_acf_field_type`, allowing for a string or callback to be passed that will append a string to the description which is populated by the field graphql_description or instructions field.

- implements this on the DatePicker and DateTimePicker field types to show that the string will be output in RFC3339 format
- updates the description of the startDate and endDate fields of the ACFE_Date_Range type to include a link to the RFC3339 spec
…contain a string but might not equal it exactly
- add translators: comments
…d-descriptions

feat: update docs Date fields to link to the RFC3339 spec
…ook_suffix

fix: admin_enqueue_scripts callback should expect a possible null value passed to it
…y' to better compensate for clone fields, specifically when groups are cloned
…s-return-null

fix: clone field within a group field type returns null values
… they're tracked for things like preview support, but also to prevent duplicate registration.

- ensure field types that return a connection are tracked in the registry. This fixes a bug related to previews not resolving, and likely also prevents duplicate registration of some fields in some cases.
…inst previews

- update TextFieldTest.php to test querying against a preview
…1 as the published image, 1 as the preview image, for example)

- update ImageFieldTest to test querying the image field on a post and querying the image field on a preview
…mage-fields

fix: image fields (and other connection fields) not properly resolving when queried `asPreview`
@jasonbahl jasonbahl self-assigned this Mar 15, 2024
@coveralls
Copy link

coveralls commented Mar 15, 2024

Pull Request Test Coverage Report for Build 5c78edd3b1f2732c82a7d25806c72179be428609-PR-190

Details

  • 30 of 38 (78.95%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.2%) to 63.714%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Admin/PostTypeRegistration.php 0 2 0.0%
src/Admin/TaxonomyRegistration.php 0 2 0.0%
src/FieldConfig.php 10 12 83.33%
src/FieldType/FlexibleContent.php 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/FieldConfig.php 1 91.84%
Totals Coverage Status
Change from base Build 5d500c00d29d353301ba4f6d1afae06e3debe427: 1.2%
Covered Lines: 2093
Relevant Lines: 3285

💛 - Coveralls

@jasonbahl jasonbahl merged commit 153761c into main Mar 15, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants