LiteSpeed broken layout incompatibility #2776

piotrbak · 2020-06-15T20:53:02Z

Describe the bug
When using LiteSpeed (and seems that in connection with WooCommerce), double click on the WooCommerce page creates a broken layout cache.

I wasn't able to replicate this on pages other than WooCommerce ones.

To Reproduce
Steps to reproduce the behavior:

On WooCommerce site hosted on LiteSpeed
Clear all caches, including OPCache
Go to the taxonomy page
Double-click on the chosen product
See if the layout is broken

Expected behavior
WP Rocket caching the pages correctly.

Screenshots
Double click on the product page:
https://jmp.sh/ve9YdcY

Double click on taxonomy page:
https://jmp.sh/4n8e1nJ

Additional context
I was working on one ticket related to this issue, I was pretty sure that it's related to the HTTP/3 protocol and QUIC, but I have a second ticket with HTTP/2.

Nothing special in the WP Debug log. The cached HTML file just stops at some point.

In the first ticket, it was happening only for mobiles (still not for all), in the second one, I've reproduced it on the desktop.

I'm getting more information regarding the second environment, as it seems that it has a shared cache directory.

Related tickets:

We have access to the full cPanel and we can test there whatever needed:
https://secure.helpscout.net/conversation/1173326494/167375?folderId=2415573
New ticket (from screencast), still getting more information about the environment:
https://secure.helpscout.net/conversation/1165493465/165403?folderId=2415573

Backlog Grooming (for WP Media dev team use only)

Reproduce the problem
Identify the root cause
Scope a solution
Estimate the effort

BenHarris · 2020-06-16T08:52:57Z

We hit this today too. Have temporarily rolled back to 3.5.5.1

piotrbak · 2020-06-16T19:14:27Z

@BenHarris This issue is not related to this one:
#2767

Please check if the 3.6.0.3 version fixes your problem. If not, contact us via support and mention this GitHub issue.

vmanthos · 2020-07-22T13:24:46Z

There is a related ticket here: https://secure.helpscout.net/conversation/1213394116/177393
Check my notes: https://secure.helpscout.net/conversation/1213394116/177393/#thread-3526587635

This is WIP, but I'll be on leave, so I'm adding here my findings so far.

As Piotr found, the issue can occur when there are multiple clicks on the link of a product. I found this can happen with normal pages too. This site is hosted on a LiteSpeed server, as in previous cases.

When doing multiple clicked, some of the requests are canceled:

Full-Scale image > https://i.vgy.me/TWjbn5.jpg

The caching process stopped in these two checks:

wp-rocket/inc/classes/Buffer/class-tests.php

Lines 318 to 322 in b1fdd13

    
           		if ( ! function_exists( 'rocket_mkdir_p' ) ) { 
        
           			// Uh? 
        
           			$this->set_error( 'WP Rocket not found - page cannot be cached.' ); 
        
           			return false; 
        
           		}

wp-rocket/inc/classes/Buffer/class-tests.php

Lines 324 to 328 in b1fdd13

    
           if ( strlen( $buffer ) <= 255 ) { 
        
           	// Buffer length must be > 255 (IE does not read pages under 255 c). 
        
           	$this->set_error( 'Buffer content under 255 caracters.' ); 
        
           	return false; 
        
           }

One obviously passes through resulting into only a part of the page being cached, e.g. http://snippi.com/s/pvej1ql

vmanthos · 2020-09-07T07:07:58Z

Potentially related tickets:
https://secure.helpscout.net/conversation/1274338964/192449/
https://secure.helpscout.net/conversation/1276041823/192902

vmanthos · 2020-09-21T09:56:05Z

Potentially related ticket:
https://secure.helpscout.net/conversation/1285231945/195643/

This is again a WooCommerce site on a Litespeed server.

vmanthos · 2021-01-20T10:54:28Z

A similar ticket:
https://secure.helpscout.net/conversation/1385330595/228167

Slack Convo about a potential solution:
https://wp-media.slack.com/archives/C43T1AYMQ/p1611140026043100

arunbasillal · 2021-01-21T16:19:34Z

@piotrbak Is this issue still WIP? If not, can you please update the title?

vmanthos · 2021-02-09T06:28:11Z

Potentially related ticket: https://secure.helpscout.net/conversation/1419934340/237835/

The site is hosted on a LiteSpeed server, and pages are randomly cached incomplete, e.g.: http://snippi.com/s/0rj03ck

NataliaDrause · 2021-02-14T09:50:07Z

Likely related: https://secure.helpscout.net/conversation/1420783987/238073?folderId=3864740

vmanthos · 2021-02-25T08:28:09Z

Potentially related: https://secure.helpscout.net/conversation/1434303232/241865/

camilamadronero-zz · 2021-02-25T21:33:08Z

Probably related https://secure.helpscout.net/conversation/1424294729/239107/

vmanthos · 2021-03-19T06:55:24Z

Related ticket: https://secure.helpscout.net/conversation/1458397773/249020/

AscensionAynat · 2021-03-27T12:07:30Z

Hi, is there already a solution for this issue? I'm having this problem.

sandyfigueroa · 2021-03-30T21:12:51Z

Related ticket: https://secure.helpscout.net/conversation/1460570318/249648/

The client applied the changes that Vasilis proposed and says that fixes the issue.

NataliaDrause · 2021-03-31T12:38:39Z

Likely related: https://secure.helpscout.net/conversation/1465576506/251041/

vmanthos · 2021-04-05T07:01:50Z

Related ticket: https://secure.helpscout.net/conversation/1472466353/252789/

NataliaDrause · 2021-04-05T14:24:46Z

Related: https://secure.helpscout.net/conversation/1473348791/252971

NataliaDrause · 2021-04-14T12:10:09Z

Related: https://secure.helpscout.net/conversation/1482570374/255785?folderId=3864740

…ing cache (PR #3713) * Process buffer only if there is a closing </html> * Do not look for </html> when it's a REST API request * formatting update * update pattern for unexpected spacing Co-authored-by: Rémy Perona <remperona@gmail.com>

piotrbak changed the title ~~LiteSpeed broken layout incompatibility~~ [WIP] LiteSpeed broken layout incompatibility Jun 15, 2020

arunbasillal added 3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting status: work in progress Indicates and issue or PR is in work in progress labels Sep 7, 2020

vmanthos added the needs: grooming label Jan 21, 2021

arunbasillal added the priority: high Issues which should be resolved as quickly as possible label Jan 21, 2021

piotrbak changed the title ~~[WIP] LiteSpeed broken layout incompatibility~~ LiteSpeed broken layout incompatibility Feb 15, 2021

piotrbak added severity: major Feature is not working as expected and no work around available and removed status: work in progress Indicates and issue or PR is in work in progress labels Feb 15, 2021

vmanthos mentioned this issue Mar 24, 2021

Fixes #2776 Process buffer only if there is a closing </html> tag during cache #3713

Merged

7 tasks

Tabrisrp assigned vmanthos Apr 7, 2021

Tabrisrp added effort: [XS] < 1 day of estimated development time and removed needs: grooming labels Apr 7, 2021

Tabrisrp added this to the 3.9 milestone Apr 7, 2021

Tabrisrp closed this as completed in #3713 Apr 14, 2021

Tabrisrp mentioned this issue Apr 14, 2021

3.9 release checklist #3780

Closed

13 tasks

Tabrisrp mentioned this issue May 18, 2021

3.9 #3921

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LiteSpeed broken layout incompatibility #2776

LiteSpeed broken layout incompatibility #2776

piotrbak commented Jun 15, 2020 •

edited

Loading

BenHarris commented Jun 16, 2020

piotrbak commented Jun 16, 2020

vmanthos commented Jul 22, 2020

vmanthos commented Sep 7, 2020 •

edited

Loading

vmanthos commented Sep 21, 2020

vmanthos commented Jan 20, 2021

arunbasillal commented Jan 21, 2021

vmanthos commented Feb 9, 2021 •

edited

Loading

NataliaDrause commented Feb 14, 2021

vmanthos commented Feb 25, 2021

camilamadronero-zz commented Feb 25, 2021

vmanthos commented Mar 19, 2021

AscensionAynat commented Mar 27, 2021 •

edited

Loading

sandyfigueroa commented Mar 30, 2021 •

edited

Loading

NataliaDrause commented Mar 31, 2021

vmanthos commented Apr 5, 2021

NataliaDrause commented Apr 5, 2021

NataliaDrause commented Apr 14, 2021

LiteSpeed broken layout incompatibility #2776

LiteSpeed broken layout incompatibility #2776

Comments

piotrbak commented Jun 15, 2020 • edited Loading

BenHarris commented Jun 16, 2020

piotrbak commented Jun 16, 2020

vmanthos commented Jul 22, 2020

vmanthos commented Sep 7, 2020 • edited Loading

vmanthos commented Sep 21, 2020

vmanthos commented Jan 20, 2021

arunbasillal commented Jan 21, 2021

vmanthos commented Feb 9, 2021 • edited Loading

NataliaDrause commented Feb 14, 2021

vmanthos commented Feb 25, 2021

camilamadronero-zz commented Feb 25, 2021

vmanthos commented Mar 19, 2021

AscensionAynat commented Mar 27, 2021 • edited Loading

sandyfigueroa commented Mar 30, 2021 • edited Loading

NataliaDrause commented Mar 31, 2021

vmanthos commented Apr 5, 2021

NataliaDrause commented Apr 5, 2021

NataliaDrause commented Apr 14, 2021

piotrbak commented Jun 15, 2020 •

edited

Loading

vmanthos commented Sep 7, 2020 •

edited

Loading

vmanthos commented Feb 9, 2021 •

edited

Loading

AscensionAynat commented Mar 27, 2021 •

edited

Loading

sandyfigueroa commented Mar 30, 2021 •

edited

Loading