Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Fatal error: Uncaught TypeError: Argument 1 passed to WP_Rocket\Dependencies\Minify\JS when update WPR while RUCSS is in progress #4391

Closed
4 tasks
Mai-Saad opened this issue Sep 28, 2021 · 1 comment · Fixed by #4392
Assignees
Labels
Module: dashboard priority: low Issues that can wait severity: moderate Feature isn't working as expected but has work around to get same value type: bug Indicates an unexpected problem or unintended behavior

Comments

@Mai-Saad
Copy link

Mai-Saad commented Sep 28, 2021

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version => yes
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
Fatal error added to the log file when upgrading plugin while having background process in progress

To Reproduce
Steps to reproduce the behavior:

  1. Using version 3.9.4, Enable RUCSS
  2. On the plugins page, update WPR to 3.9.4.1 or latest (While RUCSS is still in progress)
  3. Check the debug.log

Expected behavior
No Error in debug.log file

Screenshots
If applicable, add screenshots to help explain your problem.
debug.log

Additional context

  • Error is not affecting using of the dashboard nor the test site
  • We need to check while CPCSS / preload is in progress too
  • If we switched between branches in the same scenario without reactivate plugin, we will see different log error

Backlog Grooming (for WP Media dev team use only)

  • Reproduce the problem
  • Identify the root cause
  • Scope a solution
  • Estimate the effort
@Mai-Saad Mai-Saad added type: bug Indicates an unexpected problem or unintended behavior Module: dashboard priority: low Issues that can wait severity: moderate Feature isn't working as expected but has work around to get same value labels Sep 28, 2021
@piotrbak
Copy link
Contributor

Other possible error when reproducing the issue:
debug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: dashboard priority: low Issues that can wait severity: moderate Feature isn't working as expected but has work around to get same value type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants