Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude Cognito Forms plugin scripts from Minify JS #4948

Closed
4 tasks
NataliaDrause opened this issue Apr 19, 2022 · 0 comments · Fixed by #4949
Closed
4 tasks

Exclude Cognito Forms plugin scripts from Minify JS #4948

NataliaDrause opened this issue Apr 19, 2022 · 0 comments · Fixed by #4949
Assignees
@NataliaDrause
Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: minify JS priority: low Issues that can wait type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Milestone
3.11.3

Comments

@NataliaDrause
Copy link
Contributor

NataliaDrause commented Apr 19, 2022 •
edited
Loading

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version - yes
  • Used the search feature to ensure that the bug hasn’t been reported before - yes

Describe the bug
Cognito forms disappear from the page when its scripts are minified and cached.

The scripts: https://www.cognitoforms.com/f/seamless.js

Excluding cognitoforms.com from Minify JS resolved the issue.

Cognito Forms plugin
https://wordpress.org/plugins/cognito-forms/

To Reproduce
Reproduced on the customer's site.

Expected behavior
The script needs to be automatically excluded from Minify JS

Ticket: https://secure.helpscout.net/conversation/1845418664/337095?folderId=3864740

Backlog Grooming (for WP Media dev team use only)

  • Reproduce the problem
  • Identify the root cause
  • Scope a solution
  • Estimate the effort
@NataliaDrause NataliaDrause self-assigned this Apr 19, 2022
NataliaDrause added a commit that referenced this issue Apr 19, 2022
@NataliaDrause
Fixes #4948 Exclude cognitoforms.com from Minify JS
5e19bca 
Resolves issues with Cognito Forms.

Fixes #4948
@NataliaDrause NataliaDrause mentioned this issue Apr 19, 2022
Merged
6 tasks
@piotrbak piotrbak added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement 3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting priority: low Issues that can wait module: minify JS labels Apr 25, 2022
@piotrbak piotrbak added this to the 3.11.3 milestone Apr 25, 2022
Tabrisrp pushed a commit that referenced this issue May 10, 2022
@NataliaDrause
Fixes #4948 Exclude cognitoforms.com from Minify JS (#4949)
d484f91
@Tabrisrp Tabrisrp mentioned this issue May 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NataliaDrause NataliaDrause

Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: minify JS priority: low Issues that can wait type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Milestone
3.11.3
Development

Successfully merging a pull request may close this issue.

Fixes #4948 Exclude cognitoforms.com from Minify JS wp-media/wp-rocket
2 participants
@piotrbak @NataliaDrause