Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SEOPress integration for sitemap preloading #5839

Closed
wp-seopress opened this issue Mar 28, 2023 · 4 comments · Fixed by #5880
Closed

Update SEOPress integration for sitemap preloading #5839

wp-seopress opened this issue Mar 28, 2023 · 4 comments · Fixed by #5880
Assignees
@CrochetFeve0251
Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: preload needs: grooming priority: low Issues that can wait type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Milestone
3.13.2

Comments

@wp-seopress
Copy link
Contributor

https://github.com/wp-seopress/wp-rocket/tree/feat/seopress-sitemap-preloading
@wp-seopress wp-seopress mentioned this issue Mar 28, 2023
Closed
1 task
@piotrbak piotrbak added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement 3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: preload priority: low Issues that can wait labels Apr 12, 2023
@piotrbak piotrbak linked a pull request Apr 12, 2023 that will close this issue
SEOPress xml sitemap preloading replace deprecated functions #5840
Closed
1 task
@piotrbak
Copy link
Contributor

We'll need to fix some tests there

@piotrbak piotrbak added this to the 3.13.3 milestone Apr 14, 2023
@CrochetFeve0251
Copy link
Contributor

@piotrbak we would have to handle old and new version for this one, right?
I mean check the version from the plugin and then call our old logic or the new one they provided us.

@piotrbak
Copy link
Contributor

@wp-seopress Could you confirm that this change is backward compatible on your side?

@wp-seopress
Copy link
Contributor Author

@piotrbak Yes absolutely.

@CrochetFeve0251 CrochetFeve0251 self-assigned this Apr 19, 2023
@CrochetFeve0251 CrochetFeve0251 mentioned this issue Apr 19, 2023
Merged
10 tasks
@piotrbak piotrbak removed this from the 3.13.3 milestone Apr 23, 2023
@vmanthos vmanthos added this to the 3.13.2 milestone Apr 25, 2023
This was referenced May 8, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CrochetFeve0251 CrochetFeve0251

Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: preload needs: grooming priority: low Issues that can wait type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Milestone
3.13.2
4 participants
@vmanthos @CrochetFeve0251 @piotrbak @wp-seopress