-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SEOPress added new version functions #5880
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrochetFeve0251
added
type: enhancement
Improvements that slightly enhance existing functionality and are fast to implement
3rd party compatibility
Issues related to 3rd party compatibility like theme, plugin or hosting
labels
Apr 19, 2023
remyperona
reviewed
Apr 19, 2023
remyperona
reviewed
Apr 19, 2023
remyperona
approved these changes
Apr 24, 2023
vmanthos
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working as expected. 👍
NOTES
The following notices appear in the debug.log
but are related to SEOPress and not WP Rocket:
PHP Deprecated: Automatic conversion of false to array is deprecated in /shared/httpd/wprocketest/htdocs/wp-content/plugins/wp-seopress/inc/admin/wizard/admin-wizard.php on line 1585
With PHP 8.2:
PHP Deprecated: Creation of dynamic property SEOPress\Actions\Admin\Importer\AIO::$tagsAIO is deprecated in /shared/httpd/wprocketest/htdocs/wp-content/plugins/wp-seopress/src/Actions/Admin/Importer/AIO.php on line 12
PHP Deprecated: Creation of dynamic property SEOPress\Actions\Admin\Importer\RankMath::$tagsRankMath is deprecated in /shared/httpd/wprocketest/htdocs/wp-content/plugins/wp-seopress/src/Actions/Admin/Importer/RankMath.php on line 12
PHP Deprecated: Creation of dynamic property SEOPress\Actions\Front\Metas\DescriptionMeta::$tagsToStringService is deprecated in /shared/httpd/wprocketest/htdocs/wp-content/plugins/wp-seopress/src/Actions/Front/Metas/DescriptionMeta.php on line 11
PHP Deprecated: Creation of dynamic property SEOPress\Actions\Front\Metas\TitleMeta::$tagsToStringService is deprecated in /shared/httpd/wprocketest/htdocs/wp-content/plugins/wp-seopress/src/Actions/Front/Metas/TitleMeta.php on line 11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3rd party compatibility
Issues related to 3rd party compatibility like theme, plugin or hosting
type: enhancement
Improvements that slightly enhance existing functionality and are fast to implement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update SEOPress to not use anymore deprecated SEOPress functions.
Fixes #5839
Type of change
Please delete options that are not relevant.
Is the solution different from the one proposed during the grooming?
No.
How Has This Been Tested?
Checklist:
Please delete the options that are not relevant.