Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SEOPress added new version functions #5880

Merged
merged 4 commits into from
Apr 25, 2023

Conversation

CrochetFeve0251
Copy link
Contributor

@CrochetFeve0251 CrochetFeve0251 commented Apr 19, 2023

Description

Update SEOPress to not use anymore deprecated SEOPress functions.

Fixes #5839

Type of change

Please delete options that are not relevant.

  • Enhancement (non-breaking change which improves an existing functionality)

Is the solution different from the one proposed during the grooming?

No.

How Has This Been Tested?

  • Automated Tests

Checklist:

Please delete the options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@CrochetFeve0251 CrochetFeve0251 self-assigned this Apr 19, 2023
@CrochetFeve0251 CrochetFeve0251 added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement 3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting labels Apr 19, 2023
@CrochetFeve0251 CrochetFeve0251 requested a review from a team April 19, 2023 10:03
@CrochetFeve0251 CrochetFeve0251 marked this pull request as ready for review April 19, 2023 10:03
@vmanthos vmanthos self-requested a review April 24, 2023 13:04
@vmanthos vmanthos added this to the 3.13.2 milestone Apr 25, 2023
Copy link
Contributor

@vmanthos vmanthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working as expected. 👍

NOTES

The following notices appear in the debug.log but are related to SEOPress and not WP Rocket:

PHP Deprecated:  Automatic conversion of false to array is deprecated in /shared/httpd/wprocketest/htdocs/wp-content/plugins/wp-seopress/inc/admin/wizard/admin-wizard.php on line 1585

With PHP 8.2:

PHP Deprecated:  Creation of dynamic property SEOPress\Actions\Admin\Importer\AIO::$tagsAIO is deprecated in /shared/httpd/wprocketest/htdocs/wp-content/plugins/wp-seopress/src/Actions/Admin/Importer/AIO.php on line 12
PHP Deprecated:  Creation of dynamic property SEOPress\Actions\Admin\Importer\RankMath::$tagsRankMath is deprecated in /shared/httpd/wprocketest/htdocs/wp-content/plugins/wp-seopress/src/Actions/Admin/Importer/RankMath.php on line 12
PHP Deprecated:  Creation of dynamic property SEOPress\Actions\Front\Metas\DescriptionMeta::$tagsToStringService is deprecated in /shared/httpd/wprocketest/htdocs/wp-content/plugins/wp-seopress/src/Actions/Front/Metas/DescriptionMeta.php on line 11
PHP Deprecated:  Creation of dynamic property SEOPress\Actions\Front\Metas\TitleMeta::$tagsToStringService is deprecated in /shared/httpd/wprocketest/htdocs/wp-content/plugins/wp-seopress/src/Actions/Front/Metas/TitleMeta.php on line 11

@vmanthos vmanthos added this pull request to the merge queue Apr 25, 2023
Merged via the queue into develop with commit 0017284 Apr 25, 2023
@vmanthos vmanthos deleted the enhancement/5839-update-seopress branch April 25, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SEOPress integration for sitemap preloading
3 participants