Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WP Rocket deactivation modal style applied to the checkboxes in the plugins page in WordPress 6.3 #6110

Closed
camilamadronero opened this issue Aug 17, 2023 · 1 comment · Fixed by #6188
Assignees
Labels
effort: [XS] < 1 day of estimated development time module: user interface priority: medium Issues which are important, but no one will go out of business. type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Milestone

Comments

@camilamadronero
Copy link

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version - Y
  • Used the search feature to ensure that the bug hasn’t been reported before - Y

Describe the bug
WP Rocket deactivation modal styles are applied to the checkboxes in the plugins page from WordPress 6.3, causing possible UI interference. The boxes are clickable under these conditions.

Alfonso found out that the .wpr-modal-overlay selector has a z-index of 0, see: https://jmp.sh/iPcnMmXT
And the plugin the checkboxes also have a z-index of 1: https://i.imgur.com/pRCi6ZC.png

And, the changes were made in WordPress 6.3 here: https://core.trac.wordpress.org/ticket/21516 and WordPress/wordpress-develop@0b69111.

It seems to be our issue because other deactivation pop-ups use other values for z-indez, see: http://recordit.co/orURs9lJHH.

To Reproduce
Steps to reproduce the behavior:

  1. In a site with WordPress 6.3 and WP Rocket, go to the plugins page
  2. Click on WP Rocket > Deactivate button.
  3. See the issue with the checkboxes.
  4. You can click the boxes too.

Expected behavior
WP Rocket deactivation modal style is not applied to the checkboxes anymore.

Additional context
Slack thread: https://wp-media.slack.com/archives/C08N8J6VC/p1692293488219549.

@piotrbak piotrbak added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement priority: medium Issues which are important, but no one will go out of business. needs: grooming module: user interface labels Aug 28, 2023
@CrochetFeve0251
Copy link
Contributor

Reproduce the problem

I was able to reproduce the issue.

Identify the root cause

The root cause of the issue is the layover from the modal being too low.

Scope a solution

A solution would be to set the z-index from the layover to 100.
For that we wil just need to add the following CSS:

.wpr-modal-overlay {
   z-index: 100;
}

Estimate the effort

Effort XS

@piotrbak piotrbak added effort: [XS] < 1 day of estimated development time and removed needs: grooming labels Sep 12, 2023
@Miraeld Miraeld self-assigned this Sep 25, 2023
Miraeld pushed a commit that referenced this issue Sep 25, 2023
checkboxes in the plugins page in WordPress 6.3

Correct an UI issue where the checkboxes where on the foreground instead
of the background while the modal to disable WP Rocket plugin is opened.
@Mai-Saad Mai-Saad added this to the 3.15.2 milestone Oct 6, 2023
@engahmeds3ed engahmeds3ed mentioned this issue Oct 10, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: [XS] < 1 day of estimated development time module: user interface priority: medium Issues which are important, but no one will go out of business. type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
5 participants