Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send LazyLoad Background CSS Images feature data to the Support endpoint #6139

Closed
piotrbak opened this issue Sep 4, 2023 · 1 comment · Fixed by #6149
Closed

Send LazyLoad Background CSS Images feature data to the Support endpoint #6139

piotrbak opened this issue Sep 4, 2023 · 1 comment · Fixed by #6149
Assignees
Labels
effort: [XS] < 1 day of estimated development time module: lazyload background css images priority: medium Issues which are important, but no one will go out of business. type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Milestone

Comments

@piotrbak
Copy link
Contributor

piotrbak commented Sep 4, 2023

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
When sending support ticket we're automatically getting data about enabled features on the website. We should include the latest feature too.

To Reproduce
Steps to reproduce the behavior:

  1. Create a ticket and choose the website
  2. Check the HelpScout
  3. The option is not listed

Expected behavior
The option should be listed in the HelpScout

Additional context
It's about this array:

private $to_send = [

Acceptance Criteria (for WP Media team use only)

  1. If the option is enabled, it should be listed in the HelpScout ticket
@piotrbak piotrbak added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement priority: medium Issues which are important, but no one will go out of business. needs: grooming module: lazyload background css images labels Sep 4, 2023
@jeawhanlee jeawhanlee added GROOMING IN PROGRESS Use this label when the issue is currently being groomed. and removed needs: grooming labels Sep 4, 2023
@jeawhanlee
Copy link
Contributor

Reproduce the problem ❌

Did not reproduce the problem as I can see it in the code.

Identify the root cause ✅

Like @piotrbak stated above, the LL CSS Background Images option is not added to the array.

Scope a solution ✅

Add the LL CSS Background images option to be sent in the support data
'lazyload_css_bg_img' => 'Lazyload CSS Background Images'

private $to_send = [
'cache_mobile' => 'Mobile Cache',
'do_caching_mobile_files' => 'Specific Cache for Mobile',
'cache_logged_user' => 'User Cache',
'emoji' => 'Disable Emojis',
'defer_all_js' => 'Defer JS',
'delay_js' => 'Delay JS',
'async_css' => 'Load CSS asynchronously',
'lazyload' => 'Lazyload Images',
'lazyload_iframes' => 'Lazyload Iframes',
'lazyload_youtube' => 'Lazyload Youtube',
'cache_webp' => 'WebP Cache',
'minify_css' => 'Minify CSS',
'remove_unused_css' => 'Remove Unused CSS',
'minify_js' => 'Minify JS',
'minify_concatenate_js' => 'Combine JS',
'minify_google_fonts' => 'Combine Google Fonts',
'manual_preload' => 'Preload',
'preload_links' => 'Preload Links',
'cdn' => 'CDN Enabled',
'do_cloudflare' => 'Cloudflare Enabled',
'varnish_auto_purge' => 'Varnish Purge Enabled',
'control_heartbeat' => 'Hearbeat Control',
'sucury_waf_cache_sync' => 'Sucuri Add-on',
];

Estimate the effort ✅

[XS]

@jeawhanlee jeawhanlee added effort: [XS] < 1 day of estimated development time and removed GROOMING IN PROGRESS Use this label when the issue is currently being groomed. labels Sep 5, 2023
@Tabrisrp Tabrisrp self-assigned this Sep 6, 2023
@vmanthos vmanthos added this to the 3.15.0.1 milestone Sep 8, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: [XS] < 1 day of estimated development time module: lazyload background css images priority: medium Issues which are important, but no one will go out of business. type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants