Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2132 Incorrect matching for CDN rewrite #2146

Merged
merged 2 commits into from
Dec 3, 2019
Merged

Fixes #2132 Incorrect matching for CDN rewrite #2146

merged 2 commits into from
Dec 3, 2019

Conversation

Tabrisrp
Copy link
Contributor

@Tabrisrp Tabrisrp commented Dec 3, 2019

Use a more specific characters class to match against the file extension. Only match for alphanumeric characters.

@Tabrisrp Tabrisrp added type: bug Indicates an unexpected problem or unintended behavior severity: minor module: CDN labels Dec 3, 2019
@Tabrisrp Tabrisrp added this to the 3.4.3 milestone Dec 3, 2019
@Tabrisrp Tabrisrp self-assigned this Dec 3, 2019
@Screenfeed Screenfeed merged commit f254056 into branch-3.4.3 Dec 3, 2019
@Screenfeed Screenfeed deleted the fix/2132-cdn-matching branch December 3, 2019 22:29
@arunbasillal arunbasillal added the priority: low Issues that can wait label Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Screenfeed Screenfeed Screenfeed approved these changes

@crystinutzaa crystinutzaa crystinutzaa approved these changes

Assignees

@Tabrisrp Tabrisrp

Labels
module: CDN priority: low Issues that can wait type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
3.4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@Tabrisrp @Screenfeed @crystinutzaa @arunbasillal