Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add campaignid / adgroupid / adid query strings #3163

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

GeekPress
Copy link
Contributor

@GeekPress GeekPress commented Sep 28, 2020

Google Ads can redirect a visitor on a page which contains more than just gclid query string.

On our own website, our Google Ads redirect to wp-rocket.me/?campaignid={xxx}&adgroupid={xxx}&adid={xxx}&gclid={xxx}

By default, these URLs aren't cached. We needed to add campaignid, adgroupid & adid values to the "Cache Query String(s)" option. Then we can get the cached version.

@GeekPress GeekPress changed the base branch from master to develop September 28, 2020 08:13
@GeekPress GeekPress changed the title Add campaignid & adgroupid query strings Add campaignid / adgroupid / adid query strings Sep 29, 2020
@Tabrisrp Tabrisrp added module: cache type: enhancement Improvements that slightly enhance existing functionality and are fast to implement needs: qa labels Oct 8, 2020
@Tabrisrp Tabrisrp added this to the 3.7.3 milestone Oct 8, 2020
@Tabrisrp
Copy link
Contributor

Tabrisrp commented Oct 8, 2020

@wp-media/qa Ready for QA

Copy link
Contributor

@piotrbak piotrbak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected.
testrail-report-38.pdf

@Tabrisrp Tabrisrp merged commit ac588bc into develop Oct 8, 2020
@Tabrisrp Tabrisrp deleted the enhancement/improve-google-ads-query-string branch October 8, 2020 20:17
@Tabrisrp Tabrisrp removed the needs: qa label Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: cache type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants