Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude www.vbt.io/ext/vbtforms.js from JS minification #4012

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Exclude www.vbt.io/ext/vbtforms.js from JS minification #4012

merged 1 commit into from
Jul 9, 2021

Conversation

vmanthos
Copy link
Contributor

@vmanthos vmanthos commented Jun 8, 2021

Description

Related ticket: https://secure.helpscout.net/conversation/1530908636/268517/

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Is the solution different from the one proposed during the grooming?

Not relevant.

How Has This Been Tested?

  • On the customer's website.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vmanthos vmanthos requested a review from Tabrisrp June 8, 2021 07:11
@Tabrisrp Tabrisrp changed the title Exclude www.vbt.io/ext/vbtforms.js from minification Exclude www.vbt.io/ext/vbtforms.js from JS minification Jul 9, 2021
@Tabrisrp Tabrisrp added 3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: minify JS type: enhancement Improvements that slightly enhance existing functionality and are fast to implement labels Jul 9, 2021
@Tabrisrp Tabrisrp added this to the 3.9.1 milestone Jul 9, 2021
@Tabrisrp Tabrisrp merged commit 2248b67 into develop Jul 9, 2021
@Tabrisrp Tabrisrp deleted the enhancement/exclude-vbt.io-script-from-minification branch July 9, 2021 23:15
@Tabrisrp Tabrisrp mentioned this pull request Jul 16, 2021
Merged
Tabrisrp pushed a commit that referenced this pull request Jul 21, 2021
@vmanthos @Tabrisrp
Exclude www.vbt.io/ext/vbtforms.js from JS minification (PR #4012)
369d09e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tabrisrp Tabrisrp Tabrisrp approved these changes

Assignees

@vmanthos vmanthos

Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: minify JS type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Milestone
3.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@vmanthos @Tabrisrp