-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #4357 on automate generating WPR css and js file #5239
Closes #4357 on automate generating WPR css and js file #5239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good start, but to avoid the issue with merge conflicts and still be able to review/test changes before deployement, we should modify the gulp tasks (or create new one), to generate unminified versions of the wpr-admin.css
, wpr-admin-rtl.css
and wpr-admin.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of things:
- Can you run the tasks so that the unminified build are sync'ed to git
- Shouldn't the deploy build also use the
.min
suffix? - Could you update the enqueue code to be compatible with both no suffix and suffix, depending on the value of
SCRIPT_DEBUG
…eration-before-deployment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The minified files are added to gitignore but still commited, you can use git rm --cached <file>
to remove them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only the map file remaining to be removed
Do we need QA for this one? |
@piotrbak |
@engahmeds3ed How we could test this PR? |
I don't think we can test that! @jeawhanlee @Tabrisrp what do u think? |
I don't think QA will be able to test this, we might have to run a fake deploy to test this, though I tested this using the on:push and pull rquest git action, so I think @Tabrisrp would know a better way to test this. |
Yeah we don't need QA, if it was tested using different triggers, it should be fine on the release tag too. |
…eration-before-deployment
@jeawhanlee @Tabrisrp |
Description
This PR tries to close the initiative of automating the generation of WPR CSS and js files.
Fixes #4357
Type of change
Is the solution different from the one proposed during the grooming?
Slightly different from the proposed.
Checklist: