-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix preloading the sitemap with update from any version less than or equals 3.12.0.2 #5337
Conversation
Will update the fixtures and tests and be ready for review |
tests/Fixtures/inc/Engine/Preload/Activation/refreshOnUpdate.php
Outdated
Show resolved
Hide resolved
tests/Fixtures/inc/Engine/Preload/Activation/refreshOnUpdate.php
Outdated
Show resolved
Hide resolved
tests/Fixtures/inc/Engine/Preload/Activation/refreshOnUpdate.php
Outdated
Show resolved
Hide resolved
soooo where is it now ? |
@jasonb4u Since 3.12 release we changed how we deal with the preload. We save URLs and their statuses in the database, please check our documentation: If you have any further questions, please reach our Support Team. |
This is NOT allowing to select which sitemaps we want Cached. Needs option to select what we want cached |
@jasonb4u From what I can see you were using autocompatibility with SEOPress + additional sitemap, this is how it's working now too.
This is an enhancement we're discussing about and it's possible that it'll be implemented soon. Thank you. |
how is it an extra enhancement when it was in v.3.11.5 and now removed, lol. I know most of my dev friends had to roll back to 3.11.5 because you remove something that needs to be there ! |
For the initial load of the sitemap, you can use the following filter:
For the overall enhancement, please follow the following issue: Please note that we use Github for development purposes only. |
Description
We had a problem with this condition
wp-rocket/inc/Engine/Preload/Activation/Activation.php
Line 79 in a036f3c
Which means that if the new version is less than
3.12
we will preload the sitemap and this will never happen.So this PR to solve that.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Locally and fixed the fixtures
Checklist:
Please delete the options that are not relevant.