Fix preloading the sitemap with update from any version less than or equals 3.12.0.2

[engahmeds3ed]

Description

We had a problem with this condition

wp-rocket/inc/Engine/Preload/Activation/Activation.php

Line 79 in a036f3c

if ( version_compare( $new_version, '3.12.0', '>=' ) ) {

Which means that if the new version is less than 3.12 we will preload the sitemap and this will never happen.

So this PR to solve that.

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which improves an existing functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Locally and fixed the fixtures

Checklist:

Please delete the options that are not relevant.

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[engahmeds3ed]

Will update the fixtures and tests and be ready for review

[jasonb4u]

Preload SITEMAPS has disappeared, this is where it used to be

[jasonb4u]

soooo where is it now ?

[piotrbak]

@jasonb4u Since 3.12 release we changed how we deal with the preload. We save URLs and their statuses in the database, please check our documentation:
https://docs.wp-rocket.me/article/8-preload-cache

If you have any further questions, please reach our Support Team.

[jasonb4u]

This is NOT allowing to select which sitemaps we want Cached. Needs option to select what we want cached

[piotrbak]

@jasonb4u From what I can see you were using autocompatibility with SEOPress + additional sitemap, this is how it's working now too.

Needs option to select what we want cached

This is an enhancement we're discussing about and it's possible that it'll be implemented soon. Thank you.

[jasonb4u]

how is it an extra enhancement when it was in v.3.11.5 and now removed, lol. I know most of my dev friends had to roll back to 3.11.5 because you remove something that needs to be there !

[piotrbak]

For the initial load of the sitemap, you can use the following filter:

function add_my_sitemap() {
return ['https://domain.com/my_sitemap.xml'];
}
add_filter( 'rocket_sitemap_preload_list', 'add_my_sitemap', PHP_INT_MAX );

For the overall enhancement, please follow the following issue:
#5394

Please note that we use Github for development purposes only.