[TITAN-298] - Update Cart by Removing and Changing Quantity #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarocavalcanti
previously approved these changes
May 18, 2023
| @@ -4,6 +4,10 @@ import styles from './ProductNotification.module.scss'; | |||
| const cx = classNames.bind(styles); | |||
|
|
|||
| const ProductNotification = ({ productNotification, cartPage }) => { | |||
| if (productNotification.close) { | |||
There was a problem hiding this comment.
Can we add a scenario for this condition?
Also, can we refactor this early return into a ternary operator in the return below?
return productNotification.close ? null : (
There was a problem hiding this comment.
We talked about testing this in the component itself but there is no assertion, nothing is rendered, so what do we test?
We could test it in Cart.test.js by making sure that the notice is shown when the max quantity is reached and then disappears when its decreased again - that's the real world scenario and the reason for introducing this prop. See line 75 of CartTable
There was a problem hiding this comment.
@alvarocavalcanti I added that test in the latest commit. Let me know what you think, probably a more accurate test of this scenario.
Co-authored-by: Alvaro Cavalcanti <alvaro.cavalcanti@wpengine.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
CartLinesUpdatemutation from Shopify API when clicking the increase and decrease quantity buttons on the cart page.We have handled a few edge cases such as:
ProductNotificationcomponent )Testing
Add a couple of items to the cart
Test increasing and decreasing the quantities on the cart page
Test decreasing to zero, it should remove that line item from cart and show a message
Test increasing the item quantity until the max available has been reached, it should show a message
The prices in both the cart table and the cart quick view component should update based on the change of quantity
Tests are added for the scenarios mentioned above