Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fixes issue with blocks not showing in the block editor when running blockset command on WP >=v6.5 #1904

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

theodesp
Copy link
Member

@theodesp theodesp commented Jun 6, 2024

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

Fixes issue when blocks not showing in the block editor when running the blockset command on WP >=v6.5

Related Issue(s):

#1880

Testing

  1. Run faust blockset to publish blocks from the examples/next/block-support package on a Wordpress Version 6.5 or higher
  2. Blocks should show in the editor list. Previously the blocks would not appear in this list.

Screenshots

Documentation Changes

Dependant PRs

Copy link

changeset-bot bot commented Jun 6, 2024

🦋 Changeset detected

Latest commit: bc2034f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@faustwp/wordpress-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 6, 2024

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@theodesp theodesp marked this pull request as ready for review June 6, 2024 09:42
@theodesp theodesp requested a review from a team as a code owner June 6, 2024 09:42
Copy link
Contributor

@ChrisWiegman ChrisWiegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with WP 6.4 and 6.5 without issue. LGTM.

@theodesp theodesp merged commit 84076cd into canary Jun 7, 2024
18 checks passed
@theodesp theodesp deleted the bug-fix-support-for-blockset-WP6-5 branch June 7, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants