fix: handle arrays before casting when normalizing attribute values (#…

…220)

.changeset/good-poems-battle.md

@@ -0,0 +1,5 @@
+---
+"@wpengine/wp-graphql-content-blocks": patch
+---
+
+fix: handle arrays before casting when using `Block::normalize_attribute_value()`

includes/Blocks/Block.php

@@ -292,10 +292,18 @@ private function create_attributes_fields( $attributes, $prefix ): array {
 	 * @param array|string $value The value
 	 * @param string       $type The type of the value
 	 * 
-	 * @return mixed
+	 * @return array|string|int|float|bool
 	 */
 	private function normalize_attribute_value( $value, $type ) {
+		// @todo use the `source` to normalize array/object values.
+		if ( is_array( $value ) ) {
+			return $value;
+		}
+
 		switch ( $type ) {
+			case 'array':
+				// If we're here, we want an array type, even though the value is not an array.
+				return isset( $value ) ? [ $value ] : [];
 			case 'string':
 				return (string) $value;
 			case 'number':

phpstan-baseline.neon

@@ -5,11 +5,6 @@ parameters:
 			count: 1
 			path: includes/Blocks/Block.php
 
-		-
-			message: "#^Cannot cast array\\|string to string\\.$#"
-			count: 1
-			path: includes/Blocks/Block.php
-
 		-
 			message: "#^Constant WPGRAPHQL_CONTENT_BLOCKS_PLUGIN_DIR not found\\.$#"
 			count: 4