fix: handle arrays before casting when normalizing attribute values

[justlevine]

What

This PR fixes the logic inside Block::normalize_attribute_values() to:

• return array values before casting to the normalized type.
• cast strings to an array if the $type is an array, but the $value is not.

No effort has been made to determine the possible Scalar types that $value can accept, and instead is assumed to only be a string|array as currently defined in the doc-block.

Why

You can't cast arrays to strings in PHP.

Additional notes

Important

At this stage, we're likely going to start seeing merge conflicts on phpstan-baseline.neon, due to multiple lines getting deleted at the source.

To resolve without waiting for @justlevine , restore the base (i.e. main branch) phpstan-baseline.neon file, and then reapply the removal of the specific allow-listed error from the phpstan-baseline.neon diff in this PR.

[changeset-bot]

🦋 Changeset detected

Latest commit: 509e25c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@wpengine/wp-graphql-content-blocks	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[mrclay]

I think it would be clearer to move this into the array case block, and if $type is not array, we shouldn't return an array, right?

[justlevine]

It's two separate guards.

This guard covers if the value is an array. If so we can't cast it to anything so we need to return early (before our switch) regardless of the expected type. (Long term the early return would be replaced with a nested validator based on the attribute source type).

The case 'array' guard is to handle where the attribute type is defined as an array, but the value isn't an array. This uncommon edge case otherwise results in a breaking GraphQL error when resolving, (since 'list_of' requires an array format for even a single value).