Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/wp graphql cs #162

Merged
merged 8 commits into from Nov 29, 2023
Merged

Chore/wp graphql cs #162

merged 8 commits into from Nov 29, 2023

Conversation

theodesp
Copy link
Member

@theodesp theodesp commented Nov 27, 2023

Description

Merge of #126 with some ignores. Commit history is maintained.

Testing

  1. Setup docker-compose
  2. Run unit tests
  3. Run lint tests

They should all pass

@theodesp theodesp requested a review from a team as a code owner November 27, 2023 14:32
Copy link

changeset-bot bot commented Nov 27, 2023

⚠️ No Changeset found

Latest commit: 820e841

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

composer.json Outdated Show resolved Hide resolved
Co-authored-by: Dovid Levine <david@axepress.dev>
@justlevine
Copy link
Contributor

@theodesp I branched this and updated to the latest wp-graphql-cs in #163, which includes the latest 3.0.x versions of WPCS/VIPCS, for your review 🙏

@mindctrl
Copy link
Member

The schema linter detected breaking changes, but it appears to be unrelated to this PR (and maybe related to WPGraphQL changes?):

Detected the following changes (73) between schemas:
[log] ✖  Field EnqueuedAsset.dependencies changed type from [EnqueuedScript] to [EnqueuedAsset]
[log] ✖  Field EnqueuedStylesheet.dependencies changed type from [EnqueuedScript] to [EnqueuedStylesheet]

Otherwise looks good to me.

@justlevine
Copy link
Contributor

The schema linter detected breaking changes, but it appears to be unrelated to this PR (and maybe related to WPGraphQL changes?):

Detected the following changes (73) between schemas:
[log] ✖  Field EnqueuedAsset.dependencies changed type from [EnqueuedScript] to [EnqueuedAsset]
[log] ✖  Field EnqueuedStylesheet.dependencies changed type from [EnqueuedScript] to [EnqueuedStylesheet]

Otherwise looks good to me.

@mindctrl 🎯. Leaking from wp-graphql/wp-graphql#2988

@theodesp theodesp merged commit 2d793cf into main Nov 29, 2023
6 of 7 checks passed
@theodesp theodesp deleted the chore/wp-graphql-cs branch November 29, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants