feat: add missing extra fields to EnqueuedAsset, EnqueuedScript and EnqueuedStylesheet
#2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justlevine
added
Type: Enhancement
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
justlevine
added
the
Needs: Tests
justlevine
force-pushed
the
feat/enqueued-asset-extra-fields
branch
from
f1b5a72
to
40023c5
Compare
justlevine
removed
the
Needs: Tests
jasonbahl
previously approved these changes
Nov 14, 2023
jasonbahl
reviewed
Nov 14, 2023
| 'src' => [ | ||
| 'resolve' => static function ( \_WP_Dependency $script ) { | ||
| return ! empty( $script->src ) && is_string( $script->src ) ? $script->src : null; | ||
| 'extraData' => [ |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| return $script->extra['data']; | ||
| }, | ||
| ], | ||
| 'strategy' => [ |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| return array_filter( $before_scripts ); | ||
| }, | ||
| ], | ||
| 'conditional' => [ |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
…ependencies both return lists of their same type.
…ueued-asset-extra-fields
| 'type' => [ 'list_of' => 'EnqueuedScript' ], | ||
| 'description' => __( 'Dependencies needed to use this asset', 'wp-graphql' ), | ||
| ], | ||
| 'extraData' => [ |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| return $script->extra['data']; | ||
| }, | ||
| ], | ||
| 'strategy' => [ |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
|
Code Climate has analyzed commit 5eb6c08 and detected 22 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
The PR registers GraphQL fields for script/style data stored in the
$extraproperty on the instance. More specifically:EnqueuedAssetafterandbeforefields, for code that is supposed to be inlined before/after the asset is called.conditionalfield, for HTML comment conditionalsextrain favor ofEnqueuedScript.extraData.argsin favor ofEnqueuedStylesheet.media.dependencyto be anEnqueuedAssetinstead of anEnqueuedScipt.EnqueuedScriptextraDatafor inline js data passed to the script (previously `EnqueuedAsset.extra)strategyand the correspondingScriptLoadingStrategyEnum.EnqueuedStylesheetisRtl,mediapath,suffix, andtitlerel, which is derived from$style->extra['alt']since it seemed clunky to use anisAltto force users to know they need to dorel={isAlt ? 'alternative stylesheet' : 'stylesheet' }Does this close any currently open issues?
Fixes #2938
Any relevant logs, error output, GraphiQL screenshots, etc?
Any other comments?
Where has this been tested?
Operating System: Ubunut 20.04 (wsl2 + devilbox + php 8.1.15)
WordPress Version: 6.4.1