Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support For Infinite Recharge #172

Merged
merged 4 commits into from
Jan 12, 2020
Merged

Added Support For Infinite Recharge #172

merged 4 commits into from
Jan 12, 2020

Conversation

wm-c
Copy link
Contributor

@wm-c wm-c commented Jan 9, 2020

I've added support for the 2020 Field Infinite Recharge

I've added support for the 2020 Field Infinite Recharge
@gftabor
Copy link
Contributor

gftabor commented Jan 11, 2020

@carbotaniuman I think this should work but it doesnt seem to for me. Am I missing something?

@carbotaniuman
Copy link
Contributor

You need to update this file @wm-c. You need to add a static for the game and call loadGameFromResource()

Copy link
Contributor

@carbotaniuman carbotaniuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename 2020-Field.png to 2020-field.png for consistency

Added 2020 infinite recharge support to pathweaver
@wm-c
Copy link
Contributor Author

wm-c commented Jan 11, 2020

I made the change and it should work now.

@wm-c wm-c changed the title Added Support For Infinite Recharged Added Support For Infinite Recharge Jan 11, 2020
@ewpratten
Copy link

Line 47 of ProjectPreferences.java should probably also be updated to use the new field as the default

Renamed a variable to fix a constancy issue
Changed the default preference to Infinite Recharge
@gftabor
Copy link
Contributor

gftabor commented Jan 12, 2020

@wm-c works fine now. Where are you getting the image, just want to make sure we use the right image before merging.
Is this figure 4-1 from the manual?

https://firstfrc.blob.core.windows.net/frc2020/Manual/Sections/Section04.pdf

@wm-c
Copy link
Contributor Author

wm-c commented Jan 12, 2020

@gftabor I got this image from figure 4-1 from the Infinite Recharge game manual.

Copy link
Contributor

@gftabor gftabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctly adds support for the new game.

@gftabor gftabor merged commit ee49c9d into wpilibsuite:master Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants