Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dark mode #231

Merged
merged 3 commits into from Apr 4, 2021
Merged

Added dark mode #231

merged 3 commits into from Apr 4, 2021

Conversation

MisCar
Copy link
Contributor

@MisCar MisCar commented Mar 27, 2021

Added a custom stylesheet with dark mode and a toggle to the welcome screen.

Screen Shot 2021-03-27 at 15 53 46

Screen Shot 2021-03-27 at 15 54 37

noamzaks and others added 3 commits March 27, 2021 15:31
Co-Authored-By: tomerisraeli <tomer.israeli19@gmail.com>
@jasondaming
Copy link
Member

Looks great only feedback I would have is it would be great if the title bar (I know it is different on every OS) changed too. SO searching didn't seem to make it sound easy but I have heard more promising things from other people.

https://stackoverflow.com/questions/28339773/javafx-how-to-change-color-of-dialog-window-title

@noamzaks
Copy link
Contributor

noamzaks commented Apr 4, 2021

Looks great only feedback I would have is it would be great if the title bar (I know it is different on every OS) changed too. SO searching didn't seem to make it sound easy but I have heard more promising things from other people.

https://stackoverflow.com/questions/28339773/javafx-how-to-change-color-of-dialog-window-title

Hi,
I'm working on it. However, I'm thinking it might be best to leave the title bar responsibility to the operating system - I know on Windows you can set it to your own color, and on Mac maybe some users would prefer having the mix.
What do you think?

@jasondaming
Copy link
Member

I agree there seems to be no clean solution. I am going to merge this.

@jasondaming jasondaming merged commit 1de5666 into wpilibsuite:main Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants