Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always make errors in handle creating methods throw #199

Closed
ThadHouse opened this issue Aug 12, 2016 · 0 comments
Closed

Always make errors in handle creating methods throw #199

ThadHouse opened this issue Aug 12, 2016 · 0 comments
Assignees
@ThadHouse
Milestone
2017

Comments

@ThadHouse
Copy link
Member

Currently, the HAL returns an invalid handle on any status error, but exceptions are only thrown on negative errors. This means that a HAL handle error will be thrown later, masking an actual issue. We should change the methods that create a HAL handle to always throw on any status error.
ThadHouse added a commit to ThadHouse/allwpilib that referenced this issue Aug 21, 2016
@ThadHouse
Forces exceptions to throw on HAL handle creation functions
5373c44 
Fixes wpilibsuite#199
@ThadHouse ThadHouse mentioned this issue Aug 21, 2016
Merged
ThadHouse added a commit to ThadHouse/allwpilib that referenced this issue Aug 21, 2016
@ThadHouse
Forces exceptions to throw on HAL handle creation functions
1f73add 
Fixes wpilibsuite#199
ThadHouse added a commit to ThadHouse/allwpilib that referenced this issue Aug 28, 2016
@ThadHouse
Forces exceptions to throw on HAL handle creation functions
2992bac 
Fixes wpilibsuite#199
@PeterJohnson PeterJohnson modified the milestone: 2017 Sep 5, 2016
ThadHouse added a commit to ThadHouse/allwpilib that referenced this issue Sep 10, 2016
@ThadHouse
Forces exceptions to throw on HAL handle creation functions
313bdb3 
Fixes wpilibsuite#199
PeterJohnson pushed a commit that referenced this issue Sep 30, 2016
@ThadHouse @PeterJohnson
Forces exceptions to throw on HAL handle creation functions (#209)
a656207 
Fixes #199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThadHouse ThadHouse

Labels
None yet
Projects
None yet
Milestone
2017
Development

No branches or pull requests
2 participants
@PeterJohnson @ThadHouse