#6767 drastically increases test times #6826
Comments
|
That sounds like a bug in the spline code, as it shouldn't be creating (0,0) rotations? |
|
I didn't look into it, not since they are all named "throwOnMalformed" it might be an intended garbage in garbage (and exception) out |
calcmogul
added a commit
to calcmogul/allwpilib
that referenced
this issue
Jul 12, 2024
Currently, a max iteration heuristic is used to determine when a spline is malformed. Instead, we can report a failure immediately if dx and dy are too small, because the heading won't be accurate either. Fixes wpilibsuite#6826.
calcmogul
added a commit
to calcmogul/allwpilib
that referenced
this issue
Jul 12, 2024
Currently, a max iteration heuristic is used to determine when a spline is malformed. Instead, we can report a failure immediately if dx and dy are too small, because the heading won't be accurate either. Fixes wpilibsuite#6826.
calcmogul
added a commit
to calcmogul/allwpilib
that referenced
this issue
Jul 12, 2024
Currently, a max iteration heuristic is used to determine when a spline is malformed. Instead, we can report a failure immediately if dx and dy are too small, because the heading won't be accurate either. Fixes wpilibsuite#6826.
calcmogul
added a commit
to calcmogul/allwpilib
that referenced
this issue
Jul 12, 2024
Currently, a max iteration heuristic is used to determine when a spline is malformed. Instead, we can report a failure immediately if dx and dy are too small, because the heading won't be accurate either. Fixes wpilibsuite#6826.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I don't know if this would be a problem in the real world but the change #6767 causes the wpimath tests to take a non-trivial amount of extra time.
CMake - [Before](https://github.com/wpilibsuite/allwpilib/actions/runs/984, 1021325/job/27166656196) 0.35 sec, After 3.07 sec -> ~10x
Gradle - Before - 364ms, After 43715ms - ~120x (!!)
The really bad offending tests are when a invalid spline is getting testing ex
QuinticHermiteSplineTest.ThrowsOnMalformed. If a team makes a bad spline live they will get plenty of warnings but their code might lock up.The text was updated successfully, but these errors were encountered: