[wpimath] Add optimize() to SwerveModuleState #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcmogul
requested changes
Jan 9, 2021
wpimath/src/main/native/include/frc/kinematics/SwerveModuleState.h
Outdated
Show resolved
Hide resolved
wpimath/src/main/native/include/frc/kinematics/SwerveModuleState.h
Outdated
Show resolved
Hide resolved
wpimath/src/main/java/edu/wpi/first/wpilibj/kinematics/SwerveModuleState.java
Outdated
Show resolved
Hide resolved
wpimath/src/main/java/edu/wpi/first/wpilibj/kinematics/SwerveModuleState.java
Outdated
Show resolved
Hide resolved
wpimath/src/main/java/edu/wpi/first/wpilibj/kinematics/SwerveModuleState.java
Outdated
Show resolved
Hide resolved
wpimath/src/main/native/include/frc/kinematics/SwerveModuleState.h
Outdated
Show resolved
Hide resolved
prateekma
requested changes
Jan 9, 2021
wpilibcExamples/src/main/cpp/examples/SwerveDrivePoseEstimator/cpp/SwerveModule.cpp
Outdated
Show resolved
Hide resolved
wpimath/src/main/java/edu/wpi/first/wpilibj/kinematics/SwerveModuleState.java
Outdated
Show resolved
Hide resolved
wpimath/src/main/native/include/frc/kinematics/SwerveModuleState.h
Outdated
Show resolved
Hide resolved
wpimath/src/main/java/edu/wpi/first/wpilibj/kinematics/SwerveModuleState.java
Outdated
Show resolved
Hide resolved
wpimath/src/main/native/include/frc/kinematics/SwerveModuleState.h
Outdated
Show resolved
Hide resolved
…te.h Co-authored-by: Tyler Veness <calcmogul@gmail.com>
…oduleState.java Co-authored-by: Tyler Veness <calcmogul@gmail.com>
…te.h Co-authored-by: Tyler Veness <calcmogul@gmail.com>
…oduleState.java Co-authored-by: Tyler Veness <calcmogul@gmail.com>
calcmogul
changed the title
|
You need to run spotless and wpiformat. |
PeterJohnson
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
prateekma
previously approved these changes
Jan 10, 2021
calcmogul
previously approved these changes
Jan 10, 2021
prateekma
approved these changes
Jan 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easy for teams to ensure that their modules never rotate more than 90 degrees to reach a given reference.