Refactor python scripts under upstream_utils and wpiutil #4614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcmogul
requested changes
Nov 11, 2022
|
This seems like it should be two seperate PRs- one for upstreamutils and one for datalog. |
calcmogul
reviewed
Nov 11, 2022
TheTripleV
reviewed
Nov 11, 2022
Co-authored-by: Vasista Vovveti <vasistavovveti@gmail.com>
virtuald
reviewed
Nov 11, 2022
| # Exclude all other modules | ||
| return False | ||
| # "Std" matches StdDeque, StdList, and StdVector headers. Other modules are excluded. | ||
| return bool(re.search(modules_rgx, abspath) or "Std" in f) |
There was a problem hiding this comment.
This doesn't really feel easier to read. :-/
auscompgeek
reviewed
Nov 12, 2022
Co-authored-by: David Vo <auscompgeek@users.noreply.github.com>
egeakman
requested review from
calcmogul and
auscompgeek
and removed request for
PeterJohnson,
calcmogul and
auscompgeek
calcmogul
approved these changes
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request ensures:
Overall better quality.