[cscore] CvSink: Allow specifying output PixelFormat #5943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrRedness
changed the title
PeterJohnson
requested changes
Nov 21, 2023
MrRedness
changed the title
PeterJohnson
requested changes
Nov 21, 2023
cscore/src/main/java/edu/wpi/first/cscore/CameraServerCvJNI.java
Outdated
Show resolved
Hide resolved
MrRedness
force-pushed
the
CSCore-PixelFormat-Passdown
branch
from
0f444bb
to
55bd629
Compare
MrRedness
force-pushed
the
CSCore-PixelFormat-Passdown
branch
from
aebec19
to
a559b7e
Compare
MrRedness
force-pushed
the
CSCore-PixelFormat-Passdown
branch
from
a559b7e
to
69d3547
Compare
PeterJohnson
approved these changes
Nov 22, 2023
PeterJohnson
changed the title
|
@PeterJohnson I noticed photonvision uses CameraServer to created and get a handle to a CvSink. Should CameraServer also be refactored to use the new constructor for CvSink? |
|
Probably. I assume it would just involve adding a parameter to getVideo? |
Yeah that could work. Should it be a overloaded method and leave the current (which calls the default constructor of CvSink)? |
Starlight220
pushed a commit
to Starlight220/allwpilib
that referenced
this pull request
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.