Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wpilib] Make Color::HexString() constexpr #5985

Conversation

calcmogul
Copy link
Member

No description provided.

@calcmogul calcmogul requested review from PeterJohnson and a team as code owners December 1, 2023 22:06
@calcmogul calcmogul force-pushed the wpilib-make-color-hex-string-constexpr branch from 29ff287 to 68d57c4 Compare December 1, 2023 23:15
@calcmogul calcmogul added the component: wpilibc WPILib C++ label Dec 2, 2023
@calcmogul calcmogul force-pushed the wpilib-make-color-hex-string-constexpr branch from 68d57c4 to 507a082 Compare December 3, 2023 18:13
@PeterJohnson
Copy link
Member

Does it still work to do std:string blah = col.HexString();?

@calcmogul
Copy link
Member Author

It does not. I'll work on fixing that.

@calcmogul calcmogul force-pushed the wpilib-make-color-hex-string-constexpr branch from 2f359c8 to 8a12a97 Compare December 4, 2023 00:51
@PeterJohnson PeterJohnson merged commit 90757b9 into wpilibsuite:main Dec 5, 2023
27 checks passed
@calcmogul calcmogul deleted the wpilib-make-color-hex-string-constexpr branch December 5, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants