Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sysid] Fix SSTO calculation #6301

Merged
merged 1 commit into from Jan 24, 2024
Merged

[sysid] Fix SSTO calculation #6301

merged 1 commit into from Jan 24, 2024

Conversation

calcmogul
Copy link
Member

I misread the slide the equation came from.

@calcmogul calcmogul requested a review from a team as a code owner January 23, 2024 04:32
@calcmogul
[sysid] Fix SSTO calculation
5c17c71 
I misread the slide the equation came from.
@calcmogul
Copy link
Member Author

calcmogul commented Jan 23, 2024 •
edited

The second OLS test matches what LibreOffice gives.
Screenshot_20240122_204927
sysid::OLS() normally reports adjusted R², which is different. The unadjusted R² matched.

@PeterJohnson PeterJohnson merged commit be78552 into wpilibsuite:main Jan 24, 2024
27 checks passed
@calcmogul calcmogul deleted the sysid-fix-ssto-calculation branch January 24, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterJohnson PeterJohnson PeterJohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@calcmogul @PeterJohnson