Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a basic vendor deps dependency mechanism #163

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

ThadHouse
Copy link
Member

@ThadHouse ThadHouse commented Aug 29, 2023

One of the biggest requests for vendor deps has been handling transitive dependencies. Doing this properly is a hard problem. @JCaporuscio had a suggestion for building a basic setup, to allow enabling this for many of the cases without causing a massive amount of development pain.

The basic idea of this is each dependency can have a requires and a conflictsWith block. Each of these blocks contains an array of objects, each containing 3 elements.

uuid: The uuid that is required or that is conflicting
errorMessage: An error message to be displayed to the user
onlineUrl: The url to search for this vendor dep during installation (This isn't used by this PR, but will be used for the dep loader)

Once all dependencies have been loaded, the entire dep tree is searched. If a dependency has a requires dependency that is not in the graph, the error message is printed. If a dependency has a conflictsWith dependency that is in the graph, the error message is printed.

Because this is done after loading, N level transitive deps would be supported, as would (although why...) circular deps.

This does nothing to ensure vendor deps are the correct year, or that versions match between transitive deps.

This new functionality is not automatically called. I want to move the automation into gradlerio to make configuration easier.

@ThadHouse ThadHouse merged commit a590e84 into wpilibsuite:main Sep 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant