Add DataSource.equals() #774
Conversation
| @@ -116,4 +117,13 @@ public boolean hasClients() { | |||
| return !clients.isEmpty(); | |||
| } | |||
|
|
|||
| @Override | |||
| public boolean equals(Object o) { | |||
| return o instanceof DataSource<?> && Objects.equals(((DataSource<?>) o).getId(), this.getId()); | |||
There was a problem hiding this comment.
Check that the classes are equal, not just instanceof the interface. This might blow up on interactions with destroyed sources
There was a problem hiding this comment.
How do we want this to interact with destroyed sources?
I think they don't inherit from AbstractDataSource, so they wouldn't have this impl anyway. Should they?
There was a problem hiding this comment.
Ah, if they don't extend from this class then I'm fine with the PR as is
There was a problem hiding this comment.
I haven't looked too much at the DestroyedSource impl, but theoretically this comparison might return true if the rhs was a destroyed source with the same URI. If that's possible, is it what we want?
There was a problem hiding this comment.
Comparison with a destroyed source in rhs did indeed return true. Changed to check class, and added some tests.
Should fix #720, and maybe even the disconnected source issues.