Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make matplotlib optional #104

Merged
merged 4 commits into from
Jul 7, 2023
Merged

make matplotlib optional #104

merged 4 commits into from
Jul 7, 2023

Conversation

TheTripleV
Copy link
Member

@TheTripleV TheTripleV commented Jun 18, 2023

closes #100

@TheTripleV TheTripleV marked this pull request as draft June 19, 2023 04:48
@TheTripleV TheTripleV marked this pull request as ready for review June 19, 2023 23:55
@Daltz333
Copy link
Member

Will this break any existing users (aka is it opt-out instead of opt-in)?

@sciencewhiz
Copy link
Contributor

Well the issue from #100 was asking for it to be opt-in, since it was added recently, right?

@TheTripleV
Copy link
Member Author

If matplotlib is installed, it's opt out. If matplotlib isn't installed, it doesn't run. So it should keep existing behavior.

@Daltz333
Copy link
Member

So this should only break CI environments for users. That still is pretty bad, but I'm not sure there is a better solution.

@TheTripleV
Copy link
Member Author

No it shouldn't break ci for anyone. If matplotlib isn't installed it just turns off image generation

@Daltz333
Copy link
Member

I wish there was a behavior where we automatically instead matplotlib and the user can explicitly choose not to instead it, instead of the opposite.

@TheTripleV
Copy link
Member Author

I don't think that's possible

@Daltz333 Daltz333 merged commit 7eafbd3 into wpilibsuite:main Jul 7, 2023
56 checks passed
@tony tony mentioned this pull request Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install Matplotlib as optional extra?
3 participants