Fix re-build #24
Merged
Fix re-build #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder why the tests cases didn't catch this. Could you add a html/dirhtml test case that fails without this pr and passes with it? |
done 👍, you need to create a new app for the re-build |
TheTripleV
reviewed
Sep 1, 2020
sphinxext/rediraffe.py
Outdated
| app.env.redirected | ||
| except AttributeError: | ||
| app.env.redirected = {} | ||
| redirect_json_file = Path(app.outdir) / "redirect.json" |
There was a problem hiding this comment.
Overall, looks good to me.
The one thing that sticks out is "redirect.json". Would something like "rediraffe_record.json"or "rediraffe_cache.json" be a better name? @Daltz333 what do you think?
There was a problem hiding this comment.
Good point, I've now changed the name
Daltz333
approved these changes
Sep 1, 2020
TheTripleV
pushed a commit
to TheTripleV/sphinxext-rediraffe-1
that referenced
this pull request
Sep 30, 2020
* Fix re-build * Update test_ext.py * rename JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.