Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unblocking UI when a tool button is clicked #846

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Conversation

MohamadNateqi
Copy link
Contributor

@MohamadNateqi MohamadNateqi commented Aug 1, 2024

close #843

The unblocking action was immediately called after the AJAX request. Since the AJAX request is an async process, the unblock action next to it immediately ran. Moving the unblocking code inside the AJAX response fixed the issue.

@MohamadNateqi MohamadNateqi self-assigned this Aug 1, 2024
Copy link
Member

@alexmigf alexmigf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexmigf alexmigf merged commit a7da869 into main Aug 2, 2024
@alexmigf alexmigf deleted the 843-tools-spinner branch August 2, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a spinner for buttons of Tools page
2 participants