custom-post-template.php is a page template, not a post template #455
Comments
benoitchantre
added a commit
to benoitchantre/wprig
that referenced
this issue
May 2, 2019
7 tasks
ataylorme
pushed a commit
that referenced
this issue
Jun 6, 2019
|
Closed by #456 |
felixarntz
added a commit
that referenced
this issue
Jun 20, 2019
* Asset version: use filemtime for development only (#164) When WP_DEBUG is `true`, the version number is the file modification time. When WP_DEBUG is `false`, the version number is the theme version. Closes #39. * Fix visual regressions caused by invalid CSS values (#172) Removes the extra space between the font size and unit to make the CSS valid. Closes #171. * Fix typo props @jdelia. Closes #177 * Remove duplicate styles and remove indent on first body tag. (#179) * Move remaining assets functions in assets.php (#169) Fixes #168. * Get the theme version from theme object (#176) * Remove comments from table of contents in global CSS (#188) Styles for comments are located in `comments.css`. Closes #187. * Add setting to toggle phpcs (#170) * Add PHP7 best practices (#185) * Add WP_Rig\WP_Rig namespace to codebase and thus remove function prefixes. * Fix tests. * Fix tests. * Use typehints in PHP codebase. * Use closures where applicable. * Move lazyload Customizer integration into lazyload module. * Fix incorrect typehints in filter_post_thumbnail_sizes_attr() function. * Fix typo in doc. * Fix #166: Update all references to me to "The WP Rig Contributors" (#195) * Update cover block styles (#193) Closes #191. * Fix typo * Fix #135: Incorrect value in calc expression. (#197) * Update available block selectors (#196) Cover text has been removed from Gutenberg * Set customizer script version dynamically (#200) Closes #199 * Use the theme version also for editor styles (#190) Closes #189 * Update editor styles specificity (#202) Closes #201. Props @benoitchantre * FIX #167: Simplify README.md by moving documentation to dedicated Wiki pages. (#194) * Remove template files from ignored files (#208) Fixes #207. * Remove unneeded styles (#206) Fixes #205. * Fix incorrect lazyload placeholder image causing 404. * Add 500.php and offline.php templates. (#212) * Add 500.php and offline.php templates. * Process code review feedback. * Print skip-link-focus-fix inline instead of enqueueing as deferred script (#139) * Print skip-link-focus-fix inline instead of enqueueing as defer script * Check if skip-link-focus-fix.js exists before loading it * Eliminate code duplication for JS file path * Print minified skip-link-focus-fix script directly. * Remove actual skip-link-focus-fix.js file as it is no longer used. * Update 2.0.0 changelog with latest improvements. * Update replacement function (#204) * Replace PHP Namespace with the `PHPNamespace` option in `config/themeConfig.js` * Escape backslashes * Move the string replace options to the `getStringReplacementTasks` util function * Closes #192 * Fix JS error when navigation menu is not available in page content. * Precache frontend CSS and JS assets via PWA feature plugin. * Modularize PHP into a component-based class structure for better overview, encapsulation and maintainability (#220) * Modularize PHP into a component-based class structure for better overview, encapsulation and maintainability. * Use custom PHPCS rules when running via gulp Previously the `WordPress` standard was used. However, we have tweaked things slightly and have custom rules in `phpcs.xml.dist`. gulp now uses the custom PHPCS rules in `phpcs.xml.dist`. The PHPCS gulp plugin options have also been moved to a constant rather than being defined twice. * Clarifying need to change folder name on install * Optional CSS variable conversion (#229) Allow CSS variable conversion to be a configurable option via `convertCSSVariables` in `config/themeConfig.js` and default it to `true`. <!-- Thank you for submitting a pull request to these course assets. Please provide information about the changes: What issue they fix, how they solve the issue, and why the solution works. --> ## Description <!-- Add the issue number this pull request addresses: --> Addresses issue #91 <!-- Please describe your pull request. --> ## List of changes <!-- Please describe what was changed/added. --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist: - [x] This pull request relates to a ticket. - [x] My code is tested. - [x] I want my code added to WP Rig. * Adding information about office hours (#239) * Adding information about office hours * Adding "Google" as calendar prefix * Moved info up in the readme * Clarify the installation instructions (#245) List both `npm run dev` and `npm run build` as options * Add documentation to disable custom font size (#217) * Adding link to view the WP Rig Calendar * Adjusting office hours times to UTC * Update column styles (#248) Closes #209. * Improve sass error logging (#224) Make use of [`gulp-plumber`](https://www.npmjs.com/package/gulp-plumber) and [`gulp-notify`](https://www.npmjs.com/package/gulp-notify) to log sass errors as operating system notifications. Closes #128 * Add .browserslistrc file (#227) Use `.browserslistrc` instead of definitions in `package.json` and `config/themeConfig.js` for browser lists. Closes #105 * Removing PR guideline to squash commits * Added changelog request to PR template * Creating changelog file * Use more granular template parts (#244) * Use template parts more granularly and coherently for improved reusability and child theme support. * Fix strange PHP syntax error with CSS output. * Add TODO for WordPress core enhancement. * Ensure the attachment navigation is only rendered if previous or next images are actually available. * Add changelog entry. * Add support for responsive embedded content (#219) Fixes #218. * Update changelog. * Add changelog back to readme.txt as it needs to be part of it. * Add the privacy policy link (#213) Closes #210. * Align .more-link with the content (#215) * Align .more-link with the content Fixes #214. * Align all elements with the content Elements that were initally inline (e.g. more link) were not aligned properly with the content. * Create a dedicated gulp task for screenshot.png (#254) Closes #225. `screenshot.png` was being copied along with other misc files in the `prodPrep` task. Aside from copying files to the production theme, this task also runs string replacement on the files. This was causing `screenshot.png` to be corrupt. The new `screenshot` task simply copies the screenshot file without running string replacement, nor does it perform image optimization on the file. * Exit the prodFinish task early if compress is false (#256) The task `prodFinish` creates the production `.zip` archive. Creation of the production `.zip` archive is configurable via `config.export.compress`, which defaults to `true`. There is a flaw in the logic of the `prodFinish` task. All the production files are brought in with `src`, conditionally turned into a `.zip` based on `config.export.compress`, then written to the directory above the development/production themes, e.g. `wp-content/themes`. This causes all the production files to be written to `wp-content/themes` when `config.export.compress` is `false`. This change exits the `.zip` creation process early, rather than relying of a conditional in the middle of the task, if `config.export.compress` is `false` to prevent this unwanted behaviour. * Fix no descending specificy for .wp-column-block (#259) Closes #258. Props @benoitchantre * Update PHPCompatibility to version 9 and get rid of deprecated and unnecessary ignore statements (#249) * Update PHPCompatibility to version ^9 and get rid of deprecated and unnecessary ignore statements. * Update readme. * Convert configuration files to JSON with optional ovveride (#233) * merge custom and default configs from JSON #228 * move deepmerge to dev dependencies * remove custom config file * Changing theme config file names * Removed browserslist from theme config * Updating themeConfig documentation * Add PR link to changelog * Replace wimg/php-compatibility with phpcompatibility/php-compatibility (#262) * Replace wimg/php-compatibility with phpcompatibility/php-compatibility * Set php-compatibility version to “^9” * Fix duplicate selector in content.css (#266) Closes #216 * Fixing bug to preserve CSS variables (#267) * Update config, define to preserve CSS vars * Set preserveCSSVars to be child of styles config * Added missing comma to HSL function (#272) The HSL function in line 173 was missing a comma. * Use CSS files for custom properties and media (#281) * Add new files for custom properties and custom media * Working model. * Minor fix + update to CHANGELOG.md * ehrm. oops. fixed. * Exclude custom logo from lazy loading (#198) * Fix #82: Exclude custom logo from lazy loading. * Update conditional to allow for more classes to be present. ht @felixarntz * Add `custom-logo` to blacklisted classes. Way cleaner. HT @spencerfinnell * Add `custom-logo` to blacklisted elements. * Delete old files. * Adding WP Rig logo to theme screenshot (#263) * Adding WP Rig logo to theme screenshot * Updating screenshot to show theme layout * Make sure content.css always loads for content (#141) * Making sure content.css always loads for content. Fixes #138. * Fix coding standards violations. * Add missing wp_print_styles() calls for wp-rig-content stylesheet. * Upgrade WordPress coding standards to 2.0 (#295) * Update WordPress Coding Standards to 2.x * Correct ignore for WPCS 2.0 * Add entry for WPCS 2.0 * Remove style on classes used for strutured data (#173) * Remove style on classes used for strutured data Fixes #39. * Minimize changes: only remove styles from .hentry * Replace require-uncached with import-fresh (#296) Addresses #280. [`require-uncached`](https://www.npmjs.com/package/require-uncached) has been deprecated in favor of [`import-fresh`](https://www.npmjs.com/package/import-fresh). * Fix inconsistent title sizes (#299) Closes #293. * Remove source map for production files (#309) * Remove source map for production files Fixes #305. * Remove useless const * Update changelog. * Remove unneeded php end tag (#320) Closes #306. * Add new custom colors and font names. Use CSS custom properties. Addresses #276. (#292) * Use numerical pagination for search results (#286) * Use numerical pagination for search reusults * Add template part for pagination * Use the_posts_pagination() everywhere * Set CSS variables for links (#325) * Enhance/print styles (#319) * Allow control over how CSS files are loaded. * Use new wp_rig()->print_styles() template tag throughout all templates. * Add changelog entry. * Better handling of copying files to prod theme bundle (#297) * Better handling of copying files to prod theme bundle - Adds a `gulpRelativeDest` function utility which can be used in `gulp.dest` to save files relative to their location in the WP Rig source directory - Moves the files to be copied to the poduction theme as-is (currently screenshot, readme, license, and `style.css`) to the default configuration - Allows an `additionalFilesToCopy` array to be defined in `config.json` so additional items, such as fonts, can be copied - Another config item was added so that folks can update to the latest WP rig and use `additionalFilesToCopy` without worrying about keeping `filesToCopy` up to date in `config.json` if it changes in `config.default.json` * Update dependencies * allowEmpty on gulp src when copying misc files * Fix wrong alignments (#291) * Load missing stylesheets to get proper alignments * Align widgets properly in 404.php * Remove unused selector * Use proper target * Remove duplicate call to wp_print_styles * Use new method to print styles * Add offline.php to sidebar exclusions * Use excerpts instead of full posts in search results (#252) * Enable search template by default Closes #251. * Add setting for search results Display Summary (default) or Full text. * Revert "Add setting for search results" This reverts commit c5c6738. * Use excerpt for search results instead of full post * Typo * Revert "Enable search template by default" This reverts commit 2b64767. * Support the optional media parameter for styles (#311) Closes #310. * Use postcss-import (#335) * Use `postcss-import` to handle `@import` statements in the build process * Remove the `preserveCSSVars` config option * Always set `'preserve': true` for `postcssCustomProperties` and `postcssCustomMedia` * Move `normalize.css` to a `reset.css` file * `import` `custom-media.css`, `custom-properties.css` and `reset.css` in `global.css` * Fix integration tests failing on WordPress 5.1 due to its renamed PHPUnit6 config file. * Don’t compile custom CSS files (#324) * Don’t compile custom CSS files * Ignore reset.css file in build * Updates the following: (#337) + @babel/preset-env@7.3.4 + ajv@6.9.2 + @babel/core@7.3.4 + autoprefixer@9.4.9 + deepmerge@3.2.0 + gulp-wp-pot@2.3.4 + eslint@5.14.1 * Move back and update CSS table of contents to global.css (#352) Closes #351. * Fix custom properties without units not evaluated (#356) Closes #355. * Update editor styles to accept custom properties and media (#367) * FIX #361: Import custom properties and custom media to editor styles to enable them in the editor. * Update editor-styles.css to properly size paragraphs. * Dynamically exclude imported files in CSS source path (#364) Add new config options: * `config.dev.styles.preserve` (boolean) - whether or not to preserve custom properties and custom media in their original form. Is directly passed to the `preserve` option of both [postcss-custom-properties](https://github.com/postcss/postcss-custom-properties#preserve) and [postcss-custom-media](https://github.com/postcss/postcss-custom-media#preserve). Defaults to `true` in `config/config.default.json`. * `config.dev.styles.customProperties` (array) - An array of CSS files, relative to the CSS source file directory, that will be passed to [the `importFrom` option of `postcss-custom-properties`](https://github.com/postcss/postcss-custom-properties#importFrom). * `config.dev.styles.customMedia` (array) - An array of CSS files, relative to the CSS source file directory, that will be passed to [the `importFrom` option of `postcss-custom-media`](https://github.com/postcss/postcss-custom-media#importFrom). * `config.dev.styles.ignoredSourceFiles` (array) - An array of CSS files, relative to the CSS source file directory, that will be ignored when building production assets. These files will *not* be ignored by `watch` tasks. * `config.dev.scripts.ignoredSourceFiles` (array) - An array of JS files, relative to the JS source file directory, that will be ignored when building production assets. These files will *not* be ignored by `watch` tasks. These new configuration options allow for the removal of hard-coded exceptions in the gulp files. This will make it easier for users to discover and change these options without needing to edit the gulp process. In order to process the values of these new options and allow relative paths to be set as values, some new gulp utility functions were also added. * `appendBaseToFilePathArray` - takes an array of file paths and appends a base path, optionally adding negation (`!`) to the beginning of the returned file paths. * `appendIgnoredSourceFiles` - Appends an array of files to be ignored to an existing file path or array of paths. A base path can also be appended to the ignored files paths so that relative file paths can be used in the array of files to ignore. * `configValueDefined` - Climbs down the object tree of `config` and determines if a given value path is defined or not. Useful for determining whether or not to use a default fallback if a `config` value is not defined. * Add missing top and bottom margin to entry meta (#354) Closes #345. * Document how to disable custom colors (#376) * Fix regular editor font size (#375) * Correct inline documentation * Replace normal by medium and increase value * Adjust sizes based on the closest modular scale Scale : 1.250 - major third * Add `rig-init` to npm scripts (#357) * Add `rig-init` to npm scripts Addresses #336. Replaces `install` with `rig-init` in the `scripts` section of `package.json` in order to decouple `npm install` and `composer install`. Users can now use `npm run rig-init` for both `npm install` and `composer install` without being forced to do `composer install` whenever `npm install` is run. * Add chanelog entry for #357 * Replace npm install with npm run rig-init to install Composer and Node dependencies * Changelog clarification * Style blockquotes like the quote block (#353) * Style blockquotes like the quote block Closes #346. * Add variables for quote border color and citation * Add missing space between content and border * Align blockquote and quote block with the content * Separate main menu toggle functionality into CSS selectors (#373) * Dynamically set postcss preserve to false for editor CSS (#369) * Use gulp-tap and postcss-custom-utils to apply custom media and custom properties to CSS source files that start with 'editor/' * Remove imports from editor CSS as custom media and custom properties are now applied automatically * Re-add imports * Dynamically set postcss preserve to false for editor files * Fix postcssCustomMediaOptions defaults and preserve * Split editor styles into their own task * Run styles and editorStyles in series * Clone arrays * Further split editorStyles and add CSS/JS clean * Add gulp alias to npm run scripts * Force preserve to false * Remove importFrom Remove `importFrom` in postcss custom properties and custom media options and `config.default.json`. `@import` in CSS source files should be used instead. * Removed unused import * Remove importFrom in editorStyles; Add CSS source path to postcss-import * Remove postcss-custom-media and postcss-custom-properties * Remove unused import * Force preserve to false for editor styles * Add preserve based on user config * Force custom-media-queries to process in postcss-preset-env * Simplify ignore to files prefixed with _ * Import custom properties and custom media in all CSS files * Don't allow preserve to be configurable * Don't import custom media and properties multiple times * Allow importFrom files to be defined in config. Default to none * Import custom media in all CSS source files * Force preserve to true for Morten * Set preserve to false for production * Revert "Set preserve to false for production" This reverts commit 52be36a. * Add _ prefix to custom property and custom media CSS source paths * Update editor styles to new convention (#332) * Update editor styles to new convention Closes #238. * Use the same font size in editor * Use the same block width in the editor * Use the same link styles in editor * Remove styles already processed from php Closes #334. * Check before adding google fonts into editor * Use the `after_setup_theme` hook * Import custom properties * Add table of contents, reorder some styles * Fix audio shortcode not aligned with the content (#385) Closes #72. * Add phpcbf to Composer scripts (#360) * Add run-phpcbf script * Add changelog entry for phpcbf in Composer scripts * Pot on prod build (#358) * Add a config.export.generatePotFile option * When `config.export.generatePotFile` is set to `false`, translation files are not generated during production builds * Only run the translation task during production builds * FIX #388. Resolve Stylelint errors. (#389) * Minor sass changes (#393) * Only implement sourcemaps in dev mode * Change debugging output style to `expanded` * Closes #323 * Cache config (#394) ## Description <!-- Add the issue number this pull request addresses: --> Don't import fresh the config all over the place. Closes #265. <!-- Please describe your pull request. --> ## List of changes <!-- Please describe what was changed/added. --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist: - [x] This pull request relates to a ticket. - [x] This code is tested. - [ ] This change has been added to CHANGELOG.md - [x] I want my code added to WP Rig. * Use more PostCSS plugins (#396) ## Description [`gulp-cssnano`](https://github.com/ben-eb/gulp-cssnano) is no longer maintained. This uses [`cssnano`](https://cssnano.co/guides/getting-started/) as a `PostCSS` plugin, instead of relying on `gulp-cssnano` as an independent step in the pipeline. Removes [`gulp-stylelint`](npmjs.com/package/gulp-stylelint) in favor of the [stylelint PostCSS plugin](stylelint.io). Adds [`postcss-reporter`](npmjs.com/package/postcss-reporter) to surface Stylelint warnings. Fixes CSS issues surfaced by Stylelint. ## List of changes <!-- Please describe what was changed/added. --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist: - [ ] This pull request relates to a ticket. - [x] This code is tested. - [ ] This change has been added to CHANGELOG.md - [x] I want my code added to WP Rig. * Update cover block styles (#386) * Fix many columns displayed as one column (#349) Keeps the read more link aligned with the content (#214). Closes #344. * Fix page links not aligned with the content (#348) Closes #342. * Single stream gulp tasks (#397) Use [`pipeline` from `mississippi`](https://www.npmjs.com/package/mississippi#pipeline) to convert the tasks in before replacement and after replacement into a single stream. This allows a much cleaner use of `pump`. The tasks to run before and after replacement are now in exported functions so that they can be re-used. This is a pre-requisite for writing tests for gulp tasks (#371). Props @phated! * Reuse styles in the editor (#390) * Reuse styles from global.css in the editor * Reuse block styles in the editor * Prevent some changes to block editor components * Update front page (#338) * Activate front-page.php (remember to move back when you're done) * Update front-page.css styles. * Move front-page.php back where it belongs. * remove unnecessary space * Removes grid layout when "Front page displays" is set to a single page. * IDEA: Add a local config file (#398) * Add local config to store sensitive info * Adding examples for config files * Set preserve to false for custom-media (#405) Closes issues #403 and #400. Set `postCSS` `preserve` to `false` for `custom-media`, while leaving it `true` for `custom-properties`. Globally import `custom-media` in configuration rather than each individual CSS file. * Remove duplicate selectors (#406) * Stylelint after PostCSS import (#408) * Run stylelint in partial files and after imports * Correct stylelint warnings * Force tabs on files when debug is on * Bring editorStyles up to date with `pipeline` * Run PostCSS twice, once with `postcss-import` on its own and again with all other PostCSS plugins * Add action wp body open (#392) * Add action wp_body_open * Use a shim to keep WordPress Core style * Move shim in a new file * Add function doc comment * Inline comments must end in a full-stop * Indent with tabs * Move gallery block styles to blocks.css (#410) * Remove duplicate selectors * Move selectors for gallery block in blocks.css * Restore alignwide and alignfull * Update Squizlabs/PHP_CodeSniffer (fix #412) (#423) * Add PostCSS Calc Plugin (#416) * Error if config that must be set is still the default value. (#418) * Global preserve false for postcss-import in editor CSS (#419) * Update pre - simplify styles (#421) * Remove minor adjustment for pre * Use a common value for margin bottom * Remove support for SASS (#425) * No Sass * Remove Sass mentions from readme and unused constant. * Update changelog. * Move media selectors to a separate file (#415) * Move media selectors to a separate file * Gallery item with is set by the grid * Move audio shortcode alignment to post and page content * Initialize navigation even if DOMContentLoaded has fired (#428) Because the `navigation.min.js` script is loaded asynchronously in the browser, it's possible that the `DOMContentLoaded` event has already fired by the time the browser processes the script. We can check the state of the DOM when the script loads to determine if the event should be used or if the script should initialize immediately. Props @jeremyfelt. * Clarify naming of wprig development folder in the installation process (#441) * Update README.md * Update README.md * Update README.md * Update README.md Removed the link to the production process further on as I do not actually think this is necessary. * Update README.md * Update README.md I liked Benoit's naming suggestion. I also tried to simplify the language as much as possible. I also took out the reference to npm run bundle, confusing if someone is brand new to working with the theme in my view. * Infinite scroll fix (#460) * Test gulp styles task (#429) * Add jest and vinyl * Add gulp styles task tests * Add configuration option for `autoprefixer` Default `grid` to `false`. For IE grid prefixes `grid` must be changed to `true` by the user in configuration. * Add gulp tests for IE grid autoprefix * Ignore `no-undef` in code sniffer * Add autoprefixer to editor styles * Lint gulp * Update dependencies * Test gulp in Travis * No backslashes in file paths for gulp watch (#493) Gulp watch uses `chokidar` under the hood, which doesn't play well with backslashes in file paths. See [paulmillr/chokidar #668](paulmillr/chokidar#668 (comment)) Windows uses backslashes in file paths frequently. A new utility function `backslashToForwardSlash` is introduced and used in file paths passed to gulp watch. File paths with forward slashes are valid for Windows in a NodeJS context, so this fixes the issues of files not being watched in Windows. Closes #492. * Fix missing editor styles in production files (#495) Closes #484. * Align the sidebar below the content (#458) Closes #457. * Fix custom post template works as a page template (#456) Closes #455. * Fix Google Fonts default subset (#446) Aligns with the default value of Google Fonts * Use existing variable instead of an hardcoded value (#452) * Prefer short array syntax (#436) Closes #435. * Let backslashToForwardSlash handle arrays of paths (#499) I got an error when running npm run rig-init: TypeError: path.replace is not a function Turns out the function sometimes receives arrays of paths, so I added support for that. Also made the replacement into an arrow function to avoid repetition of code. * Always copy, and run string replacement, on style.css (#427) Adds a new task `prodStringReplace`, which copies files required for the bundled theme but not created in a build step to the production theme and runs string replacement on them. Rename `prodFinish` to `prodCompress` as the task creates the `.zip` of the production bundle. Remove `style.css` from `filesToCopy` in the default config as it is now handled with the new `prodStringReplace` task. * Fix wrong placeholder text for custom taxonomies (#503) * Fix wrong placeholder text for custom taxonomies Closes #502 * Use taxonomy name as fallback only * Headings in _typography.css not using css variables (#463) * Color Fix * Remove color * Fix stylelint comments (#447) * Don’t disable stylelint when not needed * Disable stylelint for font family Warnings are reported by error when the quotemarks are removed for a font familiy with one word only (eg. Georgia). * Revert "Disable stylelint for font family" This reverts commit 984391c. * Remove unused selector (#511) * Use `display: swap` with Google fonts to get the content faster (#486) * Convert arrays to short syntax (#508) * Update infinite scroll container to match WP-Rig (#510) * Fix i18n for site info (#479) Closes 478. * Add support for new PWA service worker integrations (#506) * Add support for new PWA service worker integrations. * Add changelog entry. * Short array syntax * Test PHP 7.3 on Travis (#527) * Remove duplicates from Test matrix * Update all relevant tests to PHP 7.3. * Remove duplicated rules in phpcs.xml.dist (#526)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue Overview
The template
custom-post-template.phpcurrently works as a page template, not as a post template as indicated by his name.The text was updated successfully, but these errors were encountered: