Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't initialize menus until DOM is loaded #140

Merged
merged 3 commits into from
Nov 7, 2018
Merged

Conversation

bamadesigner
Copy link
Contributor

@bamadesigner bamadesigner commented Oct 11, 2018

Description

This PR addresses issue #95 by ensuring menus aren't initialized until the DOM is loaded.

I also optimized a few lines of logic, to change to test if certain variables are "falsey" instead of strict comparing for undefined because "falsey" will cover undefined and null.

List of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • This pull request relates to a ticket.
  • My code is tested.
  • I want my code added to WP Rig.

Copy link
Contributor

@hellofromtonya hellofromtonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid improvements 👍. Needs a fix for Travis and then ready to fly.

@bamadesigner
Copy link
Contributor Author

@felixarntz Travis is failing and its some kind of PHP issue? Morten said you might be the one to ping to help me figure it out.

@felixarntz
Copy link
Contributor

@bamadesigner The problem is already caused by the current master branch. #146 aims to fix it. After that is merged and you merge it into your branch, it should work properly.

@felixarntz felixarntz merged commit 24eccd2 into master Nov 7, 2018
@felixarntz felixarntz deleted the update/menu2 branch November 7, 2018 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants