-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inline documentation for new syntax; See: websharks/zencache#191 #162
Conversation
@raamdev @jaswsinc Submitting PR for step 2. Please refer to the latest commit for the updated version. Would love to hear your feedback on this and how to proceed. Thanks |
In this paragraph...
Note that ZenCache is not parsing true Regular Expression syntax in any of these fields. Instead, we are using a watered-down version of regex, where only those specific characters that you listed are treated a different way. Therefore, saying, "when not used inside square brackets" is unnecessary (i.e., incorrect in this case), because square brackets have no special meaning in our watered-down version of regex. You can simply say that So I suggest changing it to the following: A wildcard Then, you can draft a KB article that goes over this in greater detail to help clarify how this works; and perhaps show more examples that would help others understand how these can be used. For instance, if I want to exclude only the home page URI, I can do that now!
To exclude a URI that begins with
You can also show the difference between
Excludes: To exclude
Excludes: To exclude any URI that simply contains
To exclude any URI that simply contains
Excludes: |
@kristineds I'm noting two more things @jaswsinc mentioned in #163 that should go in the KB Article regarding the special syntax: |
@jaswsinc @kristineds Hmm, it looks like this was auto-closed when I merged #163. However, the inline documentation does still need to be updated. @kristineds Could you please open another PR that updates the inline documentation to include mention of the new syntax Jason describes above? |
@raamdev writes...
@kristineds I just wanted to note that Raam's latest merge included the changes you opened this PR for. So you can just start a new feature branch called: $ git checkout 000000-dev
$ git pull
$ git checkout -b feature/191-step-4 Whenever you create the link (in the Dashboard) which leads to the KBA that you write to help explain this new syntax, please use this redirection link. Once the article is published, Raam can update this so it points to the live KBA: http://zencache.com/r/watered-down-regex-syntax/ |
Add inline documentation for new syntax;
See: wpsharks/comet-cache#191