Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/191 Step 3 #163

Merged
merged 9 commits into from
Oct 21, 2015
Merged

Feature/191 Step 3 #163

merged 9 commits into from
Oct 21, 2015

Conversation

jaswrks
Copy link
Contributor

@jaswrks jaswrks commented Oct 20, 2015

Includes changes from:


  • Includes additional changes that add support for *, **, ^, and $ in a list of custom URLs.
  • Includes additional changes that add support for *, **, ^, and $ in calls to the new API Function: zencache::clearUrl($url)
  • Improves support for *, **, ^, and $ in Sitemap URIs that should be cleared also.

@jaswrks jaswrks self-assigned this Oct 20, 2015
@jaswrks
Copy link
Contributor Author

jaswrks commented Oct 21, 2015

@raamdev This is ready to be reviewed/merged now.

Note: Please merge this PR instead of #155, as this one includes all of the changes from that PR and then some.


Step 2 (i.e., inline documentation updates) are still being worked on in #162

@raamdev
Copy link
Contributor

raamdev commented Oct 21, 2015

@jaswsinc Cool! I'll start testing and reviewing this now. :-)

@raamdev
Copy link
Contributor

raamdev commented Oct 21, 2015

Tested ^/$, *, and ** with Custom URLs. All working as expected! Awesome! 💯 :-)

@raamdev
Copy link
Contributor

raamdev commented Oct 21, 2015

@jaswsinc Just to confirm, this can be merged into 000000-dev despite #162 not being finished yet, correct?

@jaswrks
Copy link
Contributor Author

jaswrks commented Oct 21, 2015

I should note that any custom URLs that are listed (to be cleared automatically) are taken almost literally. Therefore, in a Multisite Network you will need to list URLs that you want to exclude, not URIs that apply to every site in the network. I think that's desirable anyway.

The same is true for domain mapping. If you want to clear URLs for a mapped domain, the URLs that you list should include the mapped domain.

With all of that being said, since wildcards are supported, you can also do something like this to cover all domains if you need to:

http://*/path/to/something/

@jaswrks
Copy link
Contributor Author

jaswrks commented Oct 21, 2015

The scheme (i.e., http:// or https:// is ignored), and both schemes are cleared automatically.

@jaswrks
Copy link
Contributor Author

jaswrks commented Oct 21, 2015

Just to confirm, this can be merged into 000000-dev despite #162 not being finished yet, correct?

Yep :-) Great!

@raamdev raamdev merged commit 5cdd847 into 000000-dev Oct 21, 2015
@raamdev raamdev deleted the feature/191-step-3 branch October 21, 2015 03:29
@raamdev
Copy link
Contributor

raamdev commented Oct 21, 2015

@jaswsinc @kristineds Merged! Thanks! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants