-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link "Cache Stats" button in Admin Bar to the Cache Stats page #263
Conversation
@jaswsinc I've changed the Cache Stats link to: The link is not clickable as is. But if you right click it and Raam noted I may need to work on the JS too, any pointers on how to fix that? |
@@ -231,7 +231,7 @@ public function adminBarMenu(\WP_Admin_Bar &$wp_admin_bar) | |||
'id' => GLOBAL_NS.'-stats', | |||
|
|||
'title' => __('Cache Stats', SLUG_TD), | |||
'href' => '#', | |||
'href' => ''.esc_attr(add_query_arg(urlencode_deep(['page' => GLOBAL_NS.'-stats']), network_admin_url('/admin.php'))).'', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renzms You can make this a little cleaner by removing the two single-quotes; i.e., => ''.esc_attr(
on the beginning and end of this string would only be needed if there was something inside them; e.g., => 'something'.esc_attr(
. In this case there is not, so it can just be => esc_attr( ...
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renzms You can make this a little cleaner by removing the two single-quotes; i.e., => ''.esc_attr( on the beginning and end of this string would only be needed if there was something inside them; e.g., => 'something'.esc_attr(. In this case there is not, so it can just be => esc_attr( ....
Thanks for tip!
Try commenting out this line and then minify the JS file and give it a shot. |
@jaswsinc That worked! Thanks for all the tips! @raamdev Tested and ready for review! |
@renzms Tested and merged. Thanks! |
See wpsharks/comet-cache#780