Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate advanced-cache.tpl.php In a Future Release #151

Closed
jaswrks opened this issue May 9, 2014 · 6 comments
Closed

Consolidate advanced-cache.tpl.php In a Future Release #151

jaswrks opened this issue May 9, 2014 · 6 comments
Assignees
@jaswrks
Labels
enhancement todo
Milestone
v140725

Comments

@jaswrks
Copy link

jaswrks commented May 9, 2014

There are a growing number of routines shared between both the advanced-cache.php handler constructed by advanced-cache.tpl.php and the core plugin class. I think in the future it would be nice to create a common class that could be refactored to support both of these phases (i.e. it would contain all of the routines that both classes can share). This way we can avoid the duplication that we have now.

I think it would be a good idea for us to work on this sometime in the near future so we can catch it before things really get out of hand; i.e. as QC continues to grow this likely to become a bigger and bigger issue in terms of the amount of code that is being duplicated. It's leaving too much room for error in my view.

The same is true for QC lite vs. Pro; although I'm not sure what we can do about that.
@jaswrks
Copy link
Author

jaswrks commented May 9, 2014

See also, the comment I made here in the code. https://github.com/WebSharks/Quick-Cache/blob/000000-dev/quick-cache/includes/advanced-cache.tpl.php#L1062

@raamdev
Copy link
Contributor

raamdev commented May 9, 2014

Great idea! I also noticed that duplication while working between advanced-cache.tpl.php and quick-cache.inc.php. I'm glad you brought this up. I'll add this to the Future Release milestone to work on after the next release.

@raamdev raamdev added this to the Future Release milestone May 9, 2014
@jaswrks
Copy link
Author

jaswrks commented Jun 9, 2014

@raamdev Would you like any help with this one?

@raamdev
Copy link
Contributor

raamdev commented Jun 9, 2014

@jaswsinc Yes! That would be great. :) Feel free to assign this to yourself and add it to the Next Release milestone if you'd like to start working on this. Much appreciated!

@jaswrks jaswrks self-assigned this Jun 9, 2014
@jaswrks
Copy link
Author

jaswrks commented Jun 9, 2014

@raamdev Great! Assigned to me.

jaswrks pushed a commit to wpsharks/comet-cache-pro that referenced this issue Jun 12, 2014
Adding quick_cache\share class. wpsharks/comet-cache#151
b7dc3c4
jaswrks pushed a commit that referenced this issue Jun 12, 2014
Adding quick_cache\share class. #151
a0d725a
jaswrks pushed a commit to wpsharks/comet-cache-pro that referenced this issue Jun 12, 2014
@Package quick_cache\share. wpsharks/comet-cache#151
3ca2292
jaswrks pushed a commit that referenced this issue Jun 12, 2014
@Package quick_cache\share. #151
d214ed7
jaswrks pushed a commit to wpsharks/comet-cache-pro that referenced this issue Jun 12, 2014
Bringing quick_cache\share into advanced_cache. wpsharks/comet-cache#151
b130107
jaswrks pushed a commit that referenced this issue Jun 12, 2014
Bringing quick_cache\share into advanced_cache. #151
73b07e7
jaswrks pushed a commit to wpsharks/comet-cache-pro that referenced this issue Jun 12, 2014
@todo Bring shareable methods into this class. wpsharks/comet-cache#151
6d3380c
jaswrks pushed a commit that referenced this issue Jun 12, 2014
@todo Bring shareable methods into this class. #151
c37a017
jaswrks pushed a commit to wpsharks/comet-cache-pro that referenced this issue Jun 12, 2014
Adding class_exists check. wpsharks/comet-cache#151
2b46367
jaswrks pushed a commit that referenced this issue Jun 12, 2014
Adding class_exists check. #151
0372e8d
jaswrks pushed a commit to wpsharks/comet-cache-pro that referenced this issue Jun 13, 2014
Finalizing wpsharks/comet-cache#151
ad53482 
Additional work toward achieving wpsharks/comet-cache#130
Also resolves wpsharks/comet-cache#206
Also resolves wpsharks/comet-cache#95
Also resolves wpsharks/comet-cache#193
jaswrks pushed a commit that referenced this issue Jun 13, 2014
Finalizing #151
29eaf58 
Additional work toward achieving #130
Also resolves #206
Also resolves #95
Also resolves #193
This was referenced Jun 13, 2014
Closed
Closed
Merged
jaswrks pushed a commit to wpsharks/comet-cache-pro that referenced this issue Jun 13, 2014
Polyfill for {@link \__()}.
8593632 
Finalizing wpsharks/comet-cache#151
jaswrks pushed a commit that referenced this issue Jun 13, 2014
Polyfill for {@link \__()}.
16d9f13 
Finalizing #151
This was referenced Jun 14, 2014
Closed
Merged
Merged
@raamdev
Copy link
Contributor

raamdev commented Jun 17, 2014

Closed by PR #212

@raamdev raamdev closed this as completed Jun 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaswrks jaswrks

Labels
enhancement todo
Projects
None yet
Milestone
v140725
Development

No branches or pull requests
2 participants
@raamdev @jaswrks