Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move version-specific Dashboard upgrade notices to their own class #193

Closed
raamdev opened this issue Jun 4, 2014 · 2 comments
Closed

Move version-specific Dashboard upgrade notices to their own class #193

raamdev opened this issue Jun 4, 2014 · 2 comments
Labels
lite pro todo
Milestone
v140725

Comments

@raamdev
Copy link
Contributor

raamdev commented Jun 4, 2014

Version-specific upgrade notices should get their own class to keep things clean and improve long-term performance. This class can work the same way as actions.php and the actions class.

@jaswsinc writes...

What I was thinking is that these will build up over time, so they increase memory consumption by being in the core plugin file and loaded at all times; even though we only use them on activation. So, if you moved them into their own class, and loaded that class on-demand; that would reduce the overhead and help organize them better too maybe.
[...]
i.e. inside that function you could require dirname(__FILE__).'/includes/upgrade-handlers.php'; or something like that. Then instantiate that class and call upon the methods/properties that you need from the main plugin file.
Much like we do with the actions.php file.

See also in quick-cache.inc.php: the check_version() method, where these upgrade notices currently reside.
@raamdev raamdev added this to the Future Release milestone Jun 4, 2014
@raamdev
Copy link
Contributor Author

raamdev commented Jun 4, 2014

Forked from #132.

jaswrks pushed a commit to wpsharks/comet-cache-pro that referenced this issue Jun 13, 2014
Finalizing wpsharks/comet-cache#151
ad53482 
Additional work toward achieving wpsharks/comet-cache#130
Also resolves wpsharks/comet-cache#206
Also resolves wpsharks/comet-cache#95
Also resolves wpsharks/comet-cache#193
This was referenced Jun 13, 2014
Closed
Closed
@jaswrks
Copy link

jaswrks commented Jun 17, 2014

This is resolved in the two pull requests referenced above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lite pro todo
Projects
None yet
Milestone
v140725
Development

No branches or pull requests
2 participants
@raamdev @jaswrks