Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Existing Sniff] Disallow Error Silencing #83

Closed
2 tasks done
grappler opened this issue Oct 1, 2016 · 3 comments
Closed
2 tasks done

[Existing Sniff] Disallow Error Silencing #83

grappler opened this issue Oct 1, 2016 · 3 comments
Assignees

Comments

@grappler
Copy link
Member

grappler commented Oct 1, 2016

Rule type:

Error - (No) Error Control Operator @

Rule:

No PHP or JS errors.

PHP errors should not be silenced

Ref: https://make.wordpress.org/themes/handbook/review/required/#code

To do:

  • Document the check in the Theme Review handbook to the Requirements page.
  • Add existing <rule ref="Generic.PHP.NoSilencedErrors" /> sniff to the ruleset.
@ernilambar
Copy link
Member

@grappler This is currently WARNING. Is not this supposed to be ERROR?

@grappler
Copy link
Member Author

@ernilambar Yes, it should be a error.

@jrfnl
Copy link
Contributor

jrfnl commented Dec 19, 2016

PR #99 should solve that ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants