Change error silencing rule from warning to error. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
grappler
approved these changes
Dec 19, 2016
|
Tested it and it works as expected. |
|
Thanks @grappler
…On Mon, Dec 19, 2016 at 2:26 PM Ulrich Pogson ***@***.***> wrote:
Merged #99 <#99>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#99 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABs6zgBcPaWK82uqZDBrVDF-8fxVLTxgks5rJuiBgaJpZM4LRIdE>
.
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #83 (comment)
@ernilambar Care to test with this branch ?
FYI: in this case the specific sniff referenced has a public property which determines whether the sniff should throw a warning or an error. The property defaults to
false(=warning), so changing the property totruefixes this. This also changes the error code the sniff uses which is why - in this case - this is the more appropriate way to change the error type.