Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImportError with DRF >= 3.8 #22

Closed
funkindy opened this issue Aug 19, 2019 · 2 comments
Closed

ImportError with DRF >= 3.8 #22

funkindy opened this issue Aug 19, 2019 · 2 comments
Milestone
1.2

Comments

@funkindy
Copy link

funkindy commented Aug 19, 2019 •
edited
Loading

detail_route decorator was merged into action since DRF 3.8, so the line from rest_framework.decorators import detail_route causes ImportError and the app wont start:

ImportError: cannot import name 'detail_route' from 'rest_framework.decorators'

Docs:
https://www.django-rest-framework.org/community/3.8-announcement/#action-decorator-replaces-list_route-and-detail_route
sheppard added a commit that referenced this issue Aug 21, 2019
@sheppard
replace @detail_route with @action (fixes #22)
e8b230b
sheppard added a commit that referenced this issue Aug 21, 2019
@sheppard
replace @detail_route with @action (fixes #22)
b1bfeb7
@sheppard
Copy link
Member

Thanks, this will be fixed in the next release.

@sheppard
Copy link
Member

sheppard commented Sep 2, 2019

Data Wizard 1.2.0 is now available on PyPI.

@sheppard sheppard added this to the 1.2 milestone Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
2 participants
@sheppard @funkindy