Make loggers get created lazily, refactoring to support this behavior an... #8

wr0ngway · 2013-11-08T19:40:39Z

...d (hopefully) make the code more understandable

… and (hopefully) make the code more understandable

nirvdrum · 2013-11-08T19:48:29Z

lib/lumber/inheritance_registry.rb

+    end
+
+    def remove_inheritance_handler
+      return if ! defined?(Object.singleton_class.inherited_with_lumber_registry)


Not a fan of unless ?

coveralls · 2013-11-08T19:54:03Z

Coverage decreased (-76.38%) when pulling 8c2bd7b on lazy_logger into 1180cff on master.

coveralls · 2013-11-08T21:10:57Z

Coverage increased (+0.19%) when pulling 7a4e59e on lazy_logger into 1180cff on master.

coveralls · 2013-11-08T22:24:55Z

Coverage decreased (-0.1%) when pulling 71dc96f on lazy_logger into 1180cff on master.

nirvdrum · 2013-11-08T22:27:09Z

lib/lumber/inheritance_registry.rb

+
+    def find_registered_logger(clazz)
+      synchronize do
+        return nil unless clazz


If this happens often, you can pull it out of the lock safely.

coveralls · 2013-11-08T23:10:55Z

Coverage increased (+0.23%) when pulling 9a1ff9b on lazy_logger into 1180cff on master.

Make loggers get created lazily, refactoring to support this behavior…

8c2bd7b

… and (hopefully) make the code more understandable

nirvdrum reviewed Nov 8, 2013
View reviewed changes

try and fix travis error

7a4e59e

wr0ngway added 2 commits November 8, 2013 16:57

refactor a bit to add more thread safety

3712ee1

fix jruby

71dc96f

nirvdrum reviewed Nov 8, 2013
View reviewed changes

wr0ngway added 2 commits November 8, 2013 17:36

more readable

20a9666

disable coveralls for jruby

9a1ff9b

wr0ngway merged commit 9a1ff9b into master Nov 9, 2013

Provide feedback