Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): 🐛 inputs/NativeFormControl spread props #126

Merged
merged 3 commits into from
Sep 5, 2024
Merged

fix(core): 🐛 inputs/NativeFormControl spread props #126

merged 3 commits into from
Sep 5, 2024

Conversation

anantakumarghosh
Copy link
Contributor

@anantakumarghosh anantakumarghosh commented Sep 5, 2024 •
edited
Loading

Description

spread props for better handling for component
ref: #124

additionally spreads props of below:

  • NativeFormControlLabel
  • NativeFormGroup
  • NativeInputLabel

Related Issues

Testing

Checklist

  • I have performed a thorough self-review of my code.
  • I have added or updated relevant tests for my changes.
  • My code follows the project's style guidelines and best practices.
  • I have updated the documentation if necessary.
  • I have added or updated relevant comments in my code.
  • I have resolved any merge conflicts of my branch.

Screenshots (if applicable)

Additional Notes

Reviewers

Maintainer Notes

  • Has this change been tested in a staging environment?
  • Does this change introduce any breaking changes or deprecations?

@anantakumarghosh
fix(core): 🐛 spread props
2b7cd42 
spread props for better handling for component

ref: #124
@anantakumarghosh
refactor(core): 🎨 spread props
301f2a5 
spread props

ref: #124
@anantakumarghosh anantakumarghosh added the bugfix Pull Requests that fixes a bug label Sep 5, 2024
@anantakumarghosh anantakumarghosh self-assigned this Sep 5, 2024
techoneel
techoneel approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@techoneel techoneel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@techoneel techoneel merged commit baba9d7 into development Sep 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techoneel techoneel techoneel approved these changes

Assignees

@anantakumarghosh anantakumarghosh

Labels
bugfix Pull Requests that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anantakumarghosh @techoneel